You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2013/10/10 18:21:08 UTC
[Bug 55647] Error while reading content from XLSX filess.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55647
Nick Burch <ap...@gagravarr.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
I've just taken a look at the TempFile logic, and spotted we didn't have a
check to ensure that the temp file name randomly chosen wasn't already in use
In r1531040 I've added something to pick a new name if the first one is already
taken, hopefully that'll help avoid this problem for you
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: [Bug 55647] Error while reading content from XLSX filess.
Posted by Dominik Stadler <do...@gmx.at>.
Hi,
Really? Sounds strange as the files are written to just like any other. I
did a quick test with Java 1.5 and Java 1.7, both successfully remove the
files. Also after running all tests, no file is left in the directory, so
maybe this problem is gone since a some time now already?
Thanks... Dominik.
On Tue, Oct 15, 2013 at 6:42 AM, Yegor Kozlov <ye...@dinom.ru> wrote:
> > any reason why we are not simply using java.io.File.createTempFile(),
> where
> > uniqueness is guaranteed by the JVM/operating system, this would avoid
> this
> > checks and recursive calling here...
> >
>
> If I recall correctly , deleteOnExit does not work for files created by
> java.io.File.createTempFile . It was the main reason why we used a custom
> utility.
>
> Yegor
>
> > Thanks... Dominik.
> >
> >
> > On Thu, Oct 10, 2013 at 6:21 PM, <bu...@apache.org> wrote:
> >
> > > https://issues.apache.org/bugzilla/show_bug.cgi?id=55647
> > >
> > > Nick Burch <ap...@gagravarr.org> changed:
> > >
> > > What |Removed |Added
> > >
> > >
>
> ----------------------------------------------------------------------------
> > > Status|NEW |RESOLVED
> > > Resolution|--- |FIXED
> > >
> > > --- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
> > > I've just taken a look at the TempFile logic, and spotted we didn't
> have a
> > > check to ensure that the temp file name randomly chosen wasn't already
> in
> > > use
> > >
> > > In r1531040 I've added something to pick a new name if the first one is
> > > already
> > > taken, hopefully that'll help avoid this problem for you
> > >
> > > --
> > > You are receiving this mail because:
> > > You are the assignee for the bug.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> > > For additional commands, e-mail: dev-help@poi.apache.org
> > >
> > >
>
Re: [Bug 55647] Error while reading content from XLSX filess.
Posted by Yegor Kozlov <ye...@dinom.ru>.
> any reason why we are not simply using java.io.File.createTempFile(),
where
> uniqueness is guaranteed by the JVM/operating system, this would avoid
this
> checks and recursive calling here...
>
If I recall correctly , deleteOnExit does not work for files created by
java.io.File.createTempFile . It was the main reason why we used a custom
utility.
Yegor
> Thanks... Dominik.
>
>
> On Thu, Oct 10, 2013 at 6:21 PM, <bu...@apache.org> wrote:
>
> > https://issues.apache.org/bugzilla/show_bug.cgi?id=55647
> >
> > Nick Burch <ap...@gagravarr.org> changed:
> >
> > What |Removed |Added
> >
> >
----------------------------------------------------------------------------
> > Status|NEW |RESOLVED
> > Resolution|--- |FIXED
> >
> > --- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
> > I've just taken a look at the TempFile logic, and spotted we didn't
have a
> > check to ensure that the temp file name randomly chosen wasn't already
in
> > use
> >
> > In r1531040 I've added something to pick a new name if the first one is
> > already
> > taken, hopefully that'll help avoid this problem for you
> >
> > --
> > You are receiving this mail because:
> > You are the assignee for the bug.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> > For additional commands, e-mail: dev-help@poi.apache.org
> >
> >
Re: [Bug 55647] Error while reading content from XLSX filess.
Posted by Dominik Stadler <do...@gmx.at>.
Hi Nick,
any reason why we are not simply using java.io.File.createTempFile(), where
uniqueness is guaranteed by the JVM/operating system, this would avoid this
checks and recursive calling here...
Thanks... Dominik.
On Thu, Oct 10, 2013 at 6:21 PM, <bu...@apache.org> wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=55647
>
> Nick Burch <ap...@gagravarr.org> changed:
>
> What |Removed |Added
>
> ----------------------------------------------------------------------------
> Status|NEW |RESOLVED
> Resolution|--- |FIXED
>
> --- Comment #1 from Nick Burch <ap...@gagravarr.org> ---
> I've just taken a look at the TempFile logic, and spotted we didn't have a
> check to ensure that the temp file name randomly chosen wasn't already in
> use
>
> In r1531040 I've added something to pick a new name if the first one is
> already
> taken, hopefully that'll help avoid this problem for you
>
> --
> You are receiving this mail because:
> You are the assignee for the bug.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
>