[GitHub] [avro] eejbyfeldt commented on pull request #1618: AVRO-3266: Work with hadoop 3.x PathOutputComitters

[GitBox <gi...@apache.org>]

eejbyfeldt commented on PR #1618:
URL: https://github.com/apache/avro/pull/1618#issuecomment-1145818671

   > Looks reasonable good to me as well, but personally I prefer PR #1431 because it doesn't use reflection (there's no need; the `PathOutputComitter` interface is generic enough).
   > 
   > On the other hand: I don't use Hadoop, so maybe I'm missing something.
   
   As discussed in #1431 that approach does not work for hadoop 2.x and since hadoop 2 is still not EOL (Actually made a release last week: https://hadoop.apache.org/release/2.10.2.html) this approach was suggest as a way to be compatible with both versions. `PathOutputComitter` was is only introduced into hadoop 3  in https://github.com/apache/hadoop/commit/11390c2d111910b01d9c4d3e39dee49babae272f But if the need to support hadoop 2 has changed since this was originally suggested, then I also agree that the approach in #1431 is better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org