You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Noble Paul (JIRA)" <ji...@apache.org> on 2008/12/16 07:18:44 UTC
[jira] Created: (SOLR-917) RequestHandlers#handlers is a
synchronized
RequestHandlers#handlers is a synchronized
-------------------------------------------
Key: SOLR-917
URL: https://issues.apache.org/jira/browse/SOLR-917
Project: Solr
Issue Type: Improvement
Reporter: Noble Paul
{code}
private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
new HashMap<String,SolrRequestHandler>() );
{code}
this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-917) RequestHandlers#handlers is a
synchronizedMap()
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-917:
----------------------------
Attachment: SOLR-917.patch
tests pass , Please review
> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-917.patch, SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-917) RequestHandlers#handlers is a
synchronizedMap()
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-917:
----------------------------
Fix Version/s: 1.4
Priority: Minor (was: Major)
Summary: RequestHandlers#handlers is a synchronizedMap() (was: RequestHandlers#handlers is a synchronized )
> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-917) RequestHandlers#handlers is a
synchronizedMap()
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657053#action_12657053 ]
Noble Paul commented on SOLR-917:
---------------------------------
sure it will have to be tested.
If there are null keys let us put it in as empty string.
all get(null) can be done as get("")
> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-917) RequestHandlers#handlers is a
synchronized
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-917:
----------------------------
Attachment: SOLR-917.patch
the fix
> RequestHandlers#handlers is a synchronized
> -------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Attachments: SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-917) RequestHandlers#handlers is a
synchronizedMap()
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657011#action_12657011 ]
Yonik Seeley commented on SOLR-917:
-----------------------------------
Remember to test patches - this causes everything to fail since ConcurrentHashMap can't take null keys.
> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-917) RequestHandlers#handlers is a
synchronizedMap()
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-917.
----------------------------------------
Resolution: Fixed
Assignee: Shalin Shekhar Mangar
Committed revision 727372.
Thanks Noble!
> RequestHandlers#handlers is a synchronizedMap()
> -----------------------------------------------
>
> Key: SOLR-917
> URL: https://issues.apache.org/jira/browse/SOLR-917
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 1.4
>
> Attachments: SOLR-917.patch, SOLR-917.patch
>
>
> {code}
> private final Map<String, SolrRequestHandler> handlers = Collections.synchronizedMap(
> new HashMap<String,SolrRequestHandler>() );
> {code}
> this map is queried for every request and it can easily be made ConcurrentHashMap
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.