[GitHub] [incubator-hudi] ambition119 commented on a change in pull request #618: fix Schema.parse to new Schema.Parser().parse

[GitBox <gi...@apache.org>]

ambition119 commented on a change in pull request #618: fix Schema.parse to new Schema.Parser().parse
URL: https://github.com/apache/incubator-hudi/pull/618#discussion_r270286354
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/io/HoodieAppendHandle.java
 ##########
 @@ -149,9 +149,10 @@ private void init(HoodieRecord record) {
   private Optional<IndexedRecord> getIndexedRecord(HoodieRecord<T> hoodieRecord) {
     Optional recordMetadata = hoodieRecord.getData().getMetadata();
     try {
-      Optional<IndexedRecord> avroRecord = hoodieRecord.getData().getInsertValue(schema);
-
+      Optional<IndexedRecord> avroRecord = hoodieRecord.getData().getInsertValue(originalSchema);
 
 Review comment:
   > why change to `originalSchema`? may be rebase on top of master again?
   
   yes, I rebased master code [originalSchema](https://github.com/apache/incubator-hudi/blob/master/hoodie-client/src/main/java/com/uber/hoodie/io/HoodieAppendHandle.java#L152)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services