You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mengxr <gi...@git.apache.org> on 2016/06/22 16:43:47 UTC

[GitHub] spark pull request #12968: [SPARK-15064][ML] Locale support in StopWordsRemo...

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12968#discussion_r68089485
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/StopWordsRemover.scala ---
    @@ -73,22 +75,38 @@ class StopWordsRemover(override val uid: String)
       /** @group getParam */
       def getCaseSensitive: Boolean = $(caseSensitive)
     
    -  setDefault(stopWords -> StopWordsRemover.loadDefaultStopWords("english"), caseSensitive -> false)
    +  /**
    +   * Locale for doing a case sensitive comparison
    +   * Default: English locale ("en")
    +   * @see [[http://www.localeplanet.com/java/]]
    --- End diff --
    
    Please link to the official Java doc: https://docs.oracle.com/javase/8/docs/api/java/util/Locale.html or the `Locale` class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org