[jira] [Commented] (AIRFLOW-6830) AWS SNS Hook and Operator should both support Subject and MessageAttributes

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17038786#comment-17038786 ] 

ASF GitHub Bot commented on AIRFLOW-6830:
-----------------------------------------

snazzyfox commented on pull request #7451: [AIRFLOW-6830] Add Subject/MessageAttributes to SNS hook and operator
URL: https://github.com/apache/airflow/pull/7451
 
 
   Add `subject` and `message_attributes` as possible parameters for `AwsSnsHook` and `SnsPublishOperator`. Both defaults to none and are backwards compatible.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> AWS SNS Hook and Operator should both support Subject and MessageAttributes
> ---------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6830
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6830
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws, hooks, operators
>    Affects Versions: 1.10.9
>            Reporter: Luyao Yang
>            Assignee: Luyao Yang
>            Priority: Minor
>              Labels: AWS
>
> Support for the Subject field for AWS SNS was added to AwsSnsHook in [AIRFLOW-5082|https://issues.apache.org/jira/browse/AIRFLOW-5082].  MessageAttributes is another field that can be passed with any message type and should be supported.
> Furthermore, both fields should be available through SnsPublishOperator as well so we don't have to write a Python function whenever one of these fields is needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)