You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/04/22 07:21:02 UTC
[GitHub] [incubator-pegasus] foreverneverer commented on a diff in pull request #950: feat: zookeeper client support kerberos
foreverneverer commented on code in PR #950:
URL: https://github.com/apache/incubator-pegasus/pull/950#discussion_r855843413
##########
.github/workflows/ci-pull-request.yaml:
##########
@@ -63,7 +63,7 @@ jobs:
needs: lint
runs-on: ubuntu-latest
container:
- image: ghcr.io/pegasus-kv/thirdparties-bin:ubuntu1804
+ image: apachepegasus/thirdparties-bin:ubuntu1804
Review Comment:
has it updated to `apapche/pegasus`?
##########
scripts/pack_server.sh:
##########
@@ -105,13 +105,6 @@ copy_file ./rdsn/thirdparty/output/lib/libPoco*.so.* ${pack}/bin
copy_file ./rdsn/thirdparty/output/lib/libtcmalloc_and_profiler.so.4 ${pack}/bin
copy_file ./rdsn/thirdparty/output/lib/libboost*.so.1.69.0 ${pack}/bin
copy_file ./rdsn/thirdparty/output/lib/libhdfs* ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libsasl2.so.3 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libcom_err.so.3 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libgssapi_krb5.so.2 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libkrb5support.so.0 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libkrb5.so.3 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/libk5crypto.so.3 ${pack}/bin
-copy_file ./rdsn/thirdparty/output/lib/sasl2 ${pack}/bin
Review Comment:
why delete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pegasus.apache.org
For additional commands, e-mail: commits-help@pegasus.apache.org