[GitHub] [httpcomponents-client] rafiek commented on pull request #228: HTTPCLIENT-2082

[GitBox <gi...@apache.org>]

rafiek commented on pull request #228:
URL: https://github.com/apache/httpcomponents-client/pull/228#issuecomment-649529346


   > @rafiek I understand that. However we have a very similar situation with `HttpClientBuilder` in HC 4.x and it has been causing quite a bit of confusion and troubles with users who never get around to reading the API documentation. I do not want to repeat the same situation in HC 5.x.
   
   Aah, did not know that. Then how about this. I was preparing this feature to make it easier to implement a programmatic SOCKS based HttpClient. The `HttpClientBuilder` uses the `PoolingHttpClientConnectionManagerBuilder` to build a default HttpClientConnectionManager, but doesn't take into consideration to use `systemProperties`. When it does, then it would be very convenient that the builder takes in `connectionSocketFactoryRegistry` as a step for `build()`. This was part of [HTTPCLIENT-1966](https://issues.apache.org/jira/browse/HTTPCLIENT-1966), but I closed the pull request because it was preferred to implement it in HC 5.x.
   
   Should I also add the changes for HTTPCLIENT-1966 in this pull request. Making the scope bigger and the intention for these changes more clear. Maybe adding more javadoc also?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org