You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/16 18:59:13 UTC

[GitHub] [tvm] junrushao commented on a diff in pull request #13791: [TOOL][NATIVE] Android native application for deploy and run

junrushao commented on code in PR #13791:
URL: https://github.com/apache/tvm/pull/13791#discussion_r1071518805


##########
.gitmodules:
##########
@@ -19,3 +19,6 @@
 [submodule "3rdparty/OpenCL-Headers"]
 	path = 3rdparty/OpenCL-Headers
 	url = https://github.com/KhronosGroup/OpenCL-Headers.git
+[submodule "3rdparty/cnpy"]
+	path = 3rdparty/cnpy
+	url = https://github.com/rogersce/cnpy.git

Review Comment:
   I was generally less aggressive when introducing new dependency. It doesn't mean I don't like it in this case, but do you think we could use TVM's native NDArray saving methods instead?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org