You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "H145608 (via GitHub)" <gi...@apache.org> on 2026/05/20 04:17:28 UTC

[PR] [ISSUE #10247] Remove duplicate remove call in InvocationChannel [rocketmq]

H145608 opened a new pull request, #10359:
URL: https://github.com/apache/rocketmq/pull/10359

   Remove redundant second inFlightRequestMap.remove() call in writeAndFlush(). The remove was already called once at line 41 to retrieve the context. The duplicate remove at line 46 had no effect and was unnecessary.
   
   Fixes: #10247
   
   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
   
   - Fixes #issue_id
   
   ### Brief Description
   
   <!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
   
   ### How Did You Test This Change?
   
   <!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10247] Remove duplicate remove call in InvocationChannel [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10359:
URL: https://github.com/apache/rocketmq/pull/10359#issuecomment-4505866704

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10359?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.85%. Comparing base ([`a3abd51`](https://app.codecov.io/gh/apache/rocketmq/commit/a3abd5185a18f9c05a6eaec0a5aa0afb3279bf44?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`39fac5a`](https://app.codecov.io/gh/apache/rocketmq/commit/39fac5ae098cb1f891d63eec461c6e757231dd63?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on develop.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10359      +/-   ##
   =============================================
   - Coverage      48.97%   48.85%   -0.12%     
   + Complexity     13473    13437      -36     
   =============================================
     Files           1375     1375              
     Lines         100452   100451       -1     
     Branches       12973    12973              
   =============================================
   - Hits           49197    49078     -119     
   - Misses         45265    45365     +100     
   - Partials        5990     6008      +18     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/10359?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org