You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/07/01 00:22:29 UTC
[GitHub] activemq-artemis pull request #1382: ARTEMIS-1269 replication won't finish s...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1382
ARTEMIS-1269 replication won't finish synchronization
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1269
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1382.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1382
----
commit b4e5c483cabf3908beffce733522764912500f6a
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-07-01T00:19:43Z
ARTEMIS-1269 replication won't finish synchronization
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1382: ARTEMIS-1269 replication won't finish s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1382: ARTEMIS-1269 replication won't finish synchron...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1382
@jbertram thanks.. nice catch!
copy & paste error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1382: ARTEMIS-1269 replication won't finish synchron...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/1382
This is very safe to be merged.. run a lot of tests on it. will merge it myself
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1382: ARTEMIS-1269 replication won't finish s...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1382#discussion_r125150430
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java ---
@@ -210,7 +210,18 @@ public void handlePacket(final Packet packet) {
ActiveMQServerLogger.LOGGER.errorHandlingReplicationPacket(e, packet);
response = new ActiveMQExceptionMessage(ActiveMQMessageBundle.BUNDLE.replicationUnhandledError(e));
}
- channel.send(response);
+
+ if (response != null) {
+ if (logger.isTraceEnabled()) {
+ logger.trace("Returning " + response);
+ }
+
+ if (response != null) {
--- End diff --
Checking "response" for null twice here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---