You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by ajs6f <gi...@git.apache.org> on 2015/06/16 20:10:51 UTC
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/77
Move arq.cmd.* to jena-base's jena.cmd
https://issues.apache.org/jira/browse/JENA-961
This is a multi-module PR, but I could find no other way to do it: since several Jena modules depend on `jena-arq` for their command-processing, moving machinery from `jena-arq` to `jena-base` caused changes in them. However, those are minor changes (e.g. changes in imports) and the meat of the PR is where it should be, in `jena-arq` and `jena-base`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-961
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 87e07fb4d7277099642eb15e8f3973d965678e29
Author: ajs6f <aj...@virginia.edu>
Date: 2015-06-16T16:13:15Z
Removing <jena-arq>/arq.cmd in favor of <jena-base>/jena.cmd
commit dccc406223ddcd71835163d301f7c51ad2d94bd9
Author: ajs6f <aj...@virginia.edu>
Date: 2015-06-16T16:45:13Z
Reusing <jena-base>/jena.cmd classes in <jena-core>
commit 883cb89d3fd1b8383c2b033ef9e214efcf262aa6
Author: ajs6f <aj...@virginia.edu>
Date: 2015-06-16T17:50:54Z
Cleanup after moving command framework
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/77#issuecomment-113557412
Thank you. Code merged with some changes:
* "Version" was used elsewhere (jena-elephas) so I put it back.
* Didn't update rdfcat; the `BiConsumer` additions are only use that old code so it seemed better to leave the old code self contained.
* Kept `processArgs`, not `Consumer.accept`. It is only of the same signature style. The operation name to "accept" didn't seem a good name in all places in the code.
* ModVersion left in CmdGeneral.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/77#issuecomment-112548845
Moving into jena-base is probably the best first step. It separates it from gathering all the commands which may well not be good idea anyway, or at least, a pointless exercise that risks breaking people's scripts (that may not use the provided ones, or have installed copies).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/77#issuecomment-112862578
Okay, I've got `ModVersion` out to `jena-base` and moved `Version` into it as an inner class (since `ModVersion` is the only client of `Version`). We are still doing the the reflection thing because I need to track down all the classes that supply the `VERSION` constant. Then I can try to replace that machinery with something else.
@afs when you suggest handing in a callback to `ModVersion`, are you thinking that there would be an interface `Versioned` or the like that would feature a member `VersionInfo getVersion()` or something like that? And `Jena`, `ARQ` and the other classes that currently offer the `VERSION` constant, once I track them down, will instead impl that type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
Posted by ajs6f <gi...@git.apache.org>.
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/77#issuecomment-112795366
Sorry, @afs, when you say "Moving into jena-base is probably the best first step." are you referring to `ArqCmdGeneral`/`CmdGeneral`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---