You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/20 06:43:20 UTC

[GitHub] [flink] wsry opened a new pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

wsry opened a new pull request #14149:
URL: https://github.com/apache/flink/pull/14149


   ## What is the purpose of the change
   
   Fix wrong config key in JobGraphRunningUtil, we should use RestOptions.BIND_PORT instead of RestOptions.BIND_ADDRESS.
   
   ## Brief change log
   
     - Fix wrong config key in JobGraphRunningUtil, use RestOptions.BIND_PORT instead of RestOptions.BIND_ADDRESS.
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger merged pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #14149:
URL: https://github.com/apache/flink/pull/14149


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-730925448


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 02a9df9f5fcc1922cc906598e117b317655af4aa (Fri Nov 20 06:46:39 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wsry commented on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
wsry commented on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-730947969


   @rmetzger I used wrong config key in the fix of FLINK-20035, we should use RestOptions.BIND_PORT, but I used RestOptions.BIND_ADDRESS by mistake. Really sorry for that. I open this PR to fix that, could you please take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-730947533


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-730947533


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9855",
       "triggerID" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9855) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-732689172


   Thanks for the follow up fix. I'll merge it!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14149: [FLINK-20035][tests] Fix wrong config key in JobGraphRunningUtil

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14149:
URL: https://github.com/apache/flink/pull/14149#issuecomment-730947533


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9855",
       "triggerID" : "c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c090c7ec80bef6783cdd667b0d15d1f0b5fd9b57 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9855) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org