[jira] [Comment Edited] (OAK-9187) LockOperation always calls SessionDelegate.refresh before executing operations

["Angela Schreiber (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192837#comment-17192837 ] 

Angela Schreiber edited comment on OAK-9187 at 9/9/20, 12:37 PM:
-----------------------------------------------------------------

[~reschke], i agree with your sentiment about the lock implementation and that it should not be used by applications running on oak. but it seems that all kind of deprecation and replacement effort went nowhere and the broken implementation still used. the only reason why decided to give it a try is that read-operations IMHO should not explicitly call refresh but instead leave that to the RefreshStrategy. but if you feel there is too much risk involved, i would not push the change.


was (Author: anchela):
[~reschke], i agree with your sentiment about the lock implementation and that it should not be used by applications running on oak. but it seems that all kind of deprecation and replacement effort has went nowhere and the broken implementation still used. the only reason why decided to give it a try is that read-operations IMHO should not explicitly call refresh but instead leave that to the RefreshStrategy. but if you feel there is too much risk involved, i would not push the change.

> LockOperation always calls SessionDelegate.refresh before executing operations
> ------------------------------------------------------------------------------
>
>                 Key: OAK-9187
>                 URL: https://issues.apache.org/jira/browse/OAK-9187
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: jcr
>            Reporter: Angela Schreiber
>            Priority: Major
>
> [~asanso] reported that calls to {{LockManager.isLocked}} (or {{Node.isLocked}}) always results in the session being forcefully refreshed. This is inconsistent with other JCR level read operations which either don't refresh at all or only refresh in the {{SessionDelegate#prePerform}} if the {{RefreshStrategy}} in place mandates it.
> The same seems to apply for those lock-related methods that include write: The session is always refreshed upon entering the methods, while other write operations either delegate refresh to the {{RefreshStrategy}} or only refresh once changes have been committed to the underlying {{Root}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)