You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Axel (Jira)" <ji...@apache.org> on 2022/02/18 08:27:00 UTC

[jira] [Created] (THRIFT-5517) Do not generate callback-style methods in ES6 mode

Axel created THRIFT-5517:
----------------------------

             Summary: Do not generate callback-style methods in ES6 mode
                 Key: THRIFT-5517
                 URL: https://issues.apache.org/jira/browse/THRIFT-5517
             Project: Thrift
          Issue Type: Improvement
    Affects Versions: 0.16.0
            Reporter: Axel


Currently, when generating a javascript API, both promise-style functions and callback-style functions are generated. An application will likely be using only one of them and when the app is using ES6, it will be Promises. Do not generate callback-style methods in ES6 mode, as it approximately doubles the bundle size.

 

The actual changes in the generator are rather simple, we are willing to work on this if we get some feedback that other people think this is a good idea.

 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)