[GitHub] [hudi] danny0405 commented on a diff in pull request #9707: [HUDI-6855] Exclude .hoodie_partition_metadata file in base file group

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9707:
URL: https://github.com/apache/hudi/pull/9707#discussion_r1325229264


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -478,8 +479,14 @@ protected FileStatus[] listPartition(Path partitionPath) throws IOException {
    * @param statuses List of File-Status
    */
   private Stream<HoodieBaseFile> convertFileStatusesToBaseFiles(FileStatus[] statuses) {
-    Predicate<FileStatus> roFilePredicate = fileStatus -> fileStatus.getPath().getName()
-        .contains(metaClient.getTableConfig().getBaseFileFormat().getFileExtension());
+    Predicate<FileStatus> roFilePredicate = fileStatus -> {
+      String pathName = fileStatus.getPath().getName();
+      // Filter base files if:
+      // 1. file extension equals to table configured file extension

Review Comment:
   Reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org