[GitHub] [ignite] zstan commented on a change in pull request #7720: IGNITE-12898 Fix incorrect collecting cache configuration (missing CacheConfigurationEnrichment) on coordinator.

[GitBox <gi...@apache.org>]

zstan commented on a change in pull request #7720:
URL: https://github.com/apache/ignite/pull/7720#discussion_r417064117



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheConfigurationSplitterImpl.java
##########
@@ -41,11 +44,32 @@
     /** Marshaller. */
     private final Marshaller marshaller;
 
+    /** Grid kernal context. */
+    private final GridKernalContext ctx;
+
     /**
      * @param marshaller Marshaller.
+     * @param ctx Grid kernal context.
      */
-    public CacheConfigurationSplitterImpl(Marshaller marshaller) {
+    public CacheConfigurationSplitterImpl(Marshaller marshaller, GridKernalContext ctx) {
         this.marshaller = marshaller;

Review comment:
       +1 with Ivan here, if it`s necessary u may add @Nullable and check them, but not asserts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org