You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "kjozsa (via GitHub)" <gi...@apache.org> on 2024/11/08 15:08:44 UTC
[PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
kjozsa opened a new pull request, #4155:
URL: https://github.com/apache/fineract/pull/4155
Fineract has a reported security vulnerability, because it does not limit login attempts, effectively allowing brute force attacks on the login screen. These changes enforce a configurable limitation of allowed requests on certain API requests (currently applied for the login request only).
Note that the enforcement happens in each JVM separately, so for clustered deployment each node enforces limits separately. That should be considered when determining the configuration value on critical deployments.
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [X] Create/update unit or integration tests for verifying the changes made.
- [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [X] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [X] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "kjozsa (via GitHub)" <gi...@apache.org>.
kjozsa closed pull request #4155: FINERACT-2125: implement server side rate limit on Login Panel
URL: https://github.com/apache/fineract/pull/4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810688028
2. External Component (software/hardware) that implements the rate limit functionality that prevents the denial of service attacks. If we go for delegating this to that external component. Either in a explicit (documentation) or implicit way, we are considering that the APIs exposed by Apache Fineract doen't not specify a default limit on the number of API calls that a program can make; however, it is still possible to overwhelm the system with an excessive number of calls during a given period. User failure to conform an upper limit can result in system failure, with high numbers of request failures and other unexpected results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810526913
@galovics the CDN/LB must be configured to forward the real IP. I think that nowadays they do it. @kjozsa why this ticket was closed? @meonkeys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "kjozsa (via GitHub)" <gi...@apache.org>.
kjozsa closed pull request #4155: FINERACT-2125: implement server side rate limit on Login Panel
URL: https://github.com/apache/fineract/pull/4155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "kjozsa (via GitHub)" <gi...@apache.org>.
kjozsa commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2468169550
@vidakovic I investigated the Resilience4j path, but I'm not sure it supports the usecase of rate limiting per source address. Are you sure this would work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2465225296
@kjozsa ... how about using Resilience4j and not implementing our own? See here how this can be done by adding one dependency, using one annotation and a handful of application.properties entries...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810550578
"must", well, I hope so, but there's no way Fineract could guarantee it
I understand the idea with closing this unmerged is because wrapping infra could/should handle it instead. Rate limiting is built into most ingress/reverse proxy/SIEM solutions.
Honestly, it seems silly, but maybe even a ~2sec pause / spinner after clicking "Login" would be sufficient. Right now it's a little jarring how quickly I'm logged in. :laughing: That is one means of rate limit, even if it is a bit silly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810690462
Ah yes, classic denial of service. Agreed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "kjozsa (via GitHub)" <gi...@apache.org>.
kjozsa commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2465243721
doh, you're right.. I did not recall Resilience4j covering that usecase just as fine.. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2470292215
@kjozsa are you sure this is the right way to approach this security vulnerability? I mean if Fineract is being put behind a CDN/LB, the remote IP address will not be the actual client address but the CDN/LB's address.
How about just enforcing Fineract to use BCrypt with a minimum 8 characters, symbols, letters (upper,lowercase) and numbers as passwords?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810610694
1. Agree on it.
2. We delegate the solution to another component. I think that is the
reason for raising the ticket. DM
El mié, 16 abr 2025 a las 13:42, Adam Monsen ***@***.***>)
escribió:
> I think we should keep it simple. How about this:
>
> 1. pause 5sec from the UI side after a failed login attempt
> 2. add rate-limiting guidance to
> https://cwiki.apache.org/confluence/display/FINERACT/Securing+Fineract
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/4155#issuecomment-2810584318>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAVE52U67S2TGKQNOTT2Z2XDPAVCNFSM6AAAAABRNWBA3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGU4DIMZRHA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
> *meonkeys* left a comment (apache/fineract#4155)
> <https://github.com/apache/fineract/pull/4155#issuecomment-2810584318>
>
> I think we should keep it simple. How about this:
>
> 1. pause 5sec from the UI side after a failed login attempt
> 2. add rate-limiting guidance to
> https://cwiki.apache.org/confluence/display/FINERACT/Securing+Fineract
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/4155#issuecomment-2810584318>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALD2ZAVE52U67S2TGKQNOTT2Z2XDPAVCNFSM6AAAAABRNWBA3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGU4DIMZRHA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810584318
I think we should keep it simple. How about this:
1. pause 5sec from the UI side after a failed login attempt
2. add rate-limiting guidance to https://cwiki.apache.org/confluence/display/FINERACT/Securing+Fineract
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810572587
@meonkeys if the rate limit is reached in the API call, then the telecom/infra guy will do an update on the CDN/LB settings. Apache Fineract must then include the instruction about how to enable/disable that rate limit. The pause... well that must be implemented by the UI and if it exposed to internet, then at leas a recaptcha should be enabled for any click that invokes the Apache Fineract Api call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "IOhacker (via GitHub)" <gi...@apache.org>.
IOhacker commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810579951
@meonkeys If this is not implemented here... then we are treating this as any other API and not as a Financial API.... https://openid.net/wg/fapi/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2125: implement server side rate limit on Login Panel [fineract]
Posted by "meonkeys (via GitHub)" <gi...@apache.org>.
meonkeys commented on PR #4155:
URL: https://github.com/apache/fineract/pull/4155#issuecomment-2810623077
1. great!
2. component? just to be clear, I'm proposing a documentation update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org