[GitHub] [spark] yutoacts commented on a change in pull request #33890: [SPARK-36442][DOCS] Remove UserDefinedAggregateFunction reference

[GitBox <gi...@apache.org>]

yutoacts commented on a change in pull request #33890:
URL: https://github.com/apache/spark/pull/33890#discussion_r700739301



##########
File path: docs/sql-ref-syntax-ddl-create-function.md
##########
@@ -74,7 +74,6 @@ CREATE [ OR REPLACE ] [ TEMPORARY ] FUNCTION [ IF NOT EXISTS ]
     * Should extend `UDF` or `UDAF` in `org.apache.hadoop.hive.ql.exec` package.
     * Should extend `AbstractGenericUDAFResolver`, `GenericUDF`, or
       `GenericUDTF` in `org.apache.hadoop.hive.ql.udf.generic` package.
-    * Should extend `UserDefinedAggregateFunction` in `org.apache.spark.sql.expressions` package.

Review comment:
       Thanks for the review. `Aggregator` is explained in https://spark.apache.org/docs/3.1.2/sql-ref-functions-udf-aggregate.html and it is not directly relevant to `CREATE FUNCTION` because we cannot have the implementing class for `class_name` extends `Aggregator`, like `UserDefinedAggregateFunction`. So I don't think it should be mentioned here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org