You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2015/10/03 13:53:20 UTC
svn commit: r1706555 - in /subversion/branches/1.9.x-patch-fixes: ./
subversion/libsvn_client/patch.c subversion/libsvn_diff/parse-diff.c
subversion/tests/cmdline/patch_tests.py
Author: rhuijben
Date: Sat Oct 3 11:53:20 2015
New Revision: 1706555
URL: http://svn.apache.org/viewvc?rev=1706555&view=rev
Log:
On the patch fixes branch: Partially merge r1705733
Modified:
subversion/branches/1.9.x-patch-fixes/ (props changed)
subversion/branches/1.9.x-patch-fixes/subversion/libsvn_client/patch.c
subversion/branches/1.9.x-patch-fixes/subversion/libsvn_diff/parse-diff.c
subversion/branches/1.9.x-patch-fixes/subversion/tests/cmdline/patch_tests.py
Propchange: subversion/branches/1.9.x-patch-fixes/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Sat Oct 3 11:53:20 2015
@@ -94,4 +94,4 @@
/subversion/branches/verify-at-commit:1462039-1462408
/subversion/branches/verify-keep-going:1439280-1546110
/subversion/branches/wc-collate-path:1402685-1480384
-/subversion/trunk:1660545-1660547,1660549-1662901,1663003,1663183-1663184,1663338,1663347,1663355,1663374,1663450,1663530,1663671,1663697,1663706,1663738,1663749,1663791,1663991,1664035,1664078,1664080,1664084-1664085,1664187,1664191,1664193,1664200,1664344,1664476,1664480-1664481,1664483,1664489-1664490,1664507,1664520-1664521,1664523,1664526-1664527,1664531-1664532,1664588,1664593-1664594,1664596,1664653,1664664,1664672,1664674,1664684,1664927,1664938-1664940,1664978,1664984,1664997,1665164,1665195,1665213,1665259,1665318,1665437-1665438,1665609,1665611-1665612,1665845,1665850,1665852,1665886,1665894,1665896,1666096,1666258,1666270,1666272,1666379,1666449,1666690,1666832,1666851,1666965,1667101,1667106-1667107,1667120,1667228,1667233-1667235,1667249-1667250,1667258,1667290,1667301,1667471,1667691-1667693,1667699-1667700,1667715,1667941,1667976,1668320,1668598-1668600,1668602-1668603,1668607-1668608,1668618,1669743,1669746,1669749,1669945,1670139,1670149,1670152,1670329,1670337,167
0347,1670353,1671164,1671388,1672295,1672311,1672372,1672404,1672511-1672512,1672578,1672728,1673044,1673062-1673063,1673065,1673153,1673170,1673172,1673197,1673202,1673204,1673228,1673282,1673445,1673691-1673692,1673746,1673785,1673803,1674015,1674032,1674170,1674301,1674305,1674308,1674339-1674340,1674406,1674415,1674455-1674456,1674475,1674487,1674522,1674580,1674626-1674627,1674785,1674891,1675771,1675774,1676526,1676535,1676538,1676555,1676564,1676570,1676665,1676667,1676769,1677003,1677191,1677267,1677440,1678147,1678149,1678494,1678571,1678734,1678742,1678745-1678746,1678755,1678839,1678846,1678894,1678950,1678963,1679166,1679169,1679228,1679230,1679240,1679287,1679864,1679866,1679909,1680242,1680264,1680495,1680705,1680819,1681317,1682714,1682854,1683071,1683126,1683135,1683290,1683303,1683311,1683378,1683387,1684034,1684077,1684322,1684325,1684344,1684412,1684940,1685034,1685085,1686175,1686239,1686478,1686541,1686543,1686554,1686557,1686802,1686888,1686984,1687029,1687304,
1687389,1687769,1687776,1688258,1688273,1688395,1689214,1689216,1689721,1689729,1691712-1691713,1691924,1691928,1692091,1692093,1692098,1692448,1692469-1692470,1692798-1692799,1693135,1693138,1693159,1693886,1694023,1694194,1694481,1694929,1695022,1695600,1695606,1695681,1696222,1696225,1696387,1696695,1697381,1697384,1697387,1697664,1697824,1697835,1697845,1697914,1697967,1698106,1698312,1700215,1700219-1700220,1700740,1700951,1701064,1701206,1701270,1701298,1701633,1701638,1701736,1701792,1701797,1701838,1701997,1702198,1702200,1702203,1702218,1702231,1702237-1702239,1702247,1702288,1702299-1702300,1702310,1702397,1702407,1702467,1702472,1702474,1702478,1702533,1702549,1702553,1702565,1702891,1702974,1702991,1703675,1703740,1704854,1704888,1705038,1705080,1705102,1705121,1705328,1706213
+/subversion/trunk:1660545-1660547,1660549-1662901,1663003,1663183-1663184,1663338,1663347,1663355,1663374,1663450,1663530,1663671,1663697,1663706,1663738,1663749,1663791,1663991,1664035,1664078,1664080,1664084-1664085,1664187,1664191,1664193,1664200,1664344,1664476,1664480-1664481,1664483,1664489-1664490,1664507,1664520-1664521,1664523,1664526-1664527,1664531-1664532,1664588,1664593-1664594,1664596,1664653,1664664,1664672,1664674,1664684,1664927,1664938-1664940,1664978,1664984,1664997,1665164,1665195,1665213,1665259,1665318,1665437-1665438,1665609,1665611-1665612,1665845,1665850,1665852,1665886,1665894,1665896,1666096,1666258,1666270,1666272,1666379,1666449,1666690,1666832,1666851,1666965,1667101,1667106-1667107,1667120,1667228,1667233-1667235,1667249-1667250,1667258,1667290,1667301,1667471,1667691-1667693,1667699-1667700,1667715,1667941,1667976,1668320,1668598-1668600,1668602-1668603,1668607-1668608,1668618,1669743,1669746,1669749,1669945,1670139,1670149,1670152,1670329,1670337,167
0347,1670353,1671164,1671388,1672295,1672311,1672372,1672404,1672511-1672512,1672578,1672728,1673044,1673062-1673063,1673065,1673153,1673170,1673172,1673197,1673202,1673204,1673228,1673282,1673445,1673691-1673692,1673746,1673785,1673803,1674015,1674032,1674170,1674301,1674305,1674308,1674339-1674340,1674406,1674415,1674455-1674456,1674475,1674487,1674522,1674580,1674626-1674627,1674785,1674891,1675771,1675774,1676526,1676535,1676538,1676555,1676564,1676570,1676665,1676667,1676769,1677003,1677191,1677267,1677440,1678147,1678149,1678494,1678571,1678734,1678742,1678745-1678746,1678755,1678839,1678846,1678894,1678950,1678963,1679166,1679169,1679228,1679230,1679240,1679287,1679864,1679866,1679909,1680242,1680264,1680495,1680705,1680819,1681317,1682714,1682854,1683071,1683126,1683135,1683290,1683303,1683311,1683378,1683387,1684034,1684077,1684322,1684325,1684344,1684412,1684940,1685034,1685085,1686175,1686239,1686478,1686541,1686543,1686554,1686557,1686802,1686888,1686984,1687029,1687304,
1687389,1687769,1687776,1688258,1688273,1688395,1689214,1689216,1689721,1689729,1691712-1691713,1691924,1691928,1692091,1692093,1692098,1692448,1692469-1692470,1692798-1692799,1693135,1693138,1693159,1693886,1694023,1694194,1694481,1694929,1695022,1695600,1695606,1695681,1696222,1696225,1696387,1696695,1697381,1697384,1697387,1697664,1697824,1697835,1697845,1697914,1697967,1698106,1698312,1700215,1700219-1700220,1700740,1700951,1701064,1701206,1701270,1701298,1701633,1701638,1701736,1701792,1701797,1701838,1701997,1702198,1702200,1702203,1702218,1702231,1702237-1702239,1702247,1702288,1702299-1702300,1702310,1702397,1702407,1702467,1702472,1702474,1702478,1702533,1702549,1702553,1702565,1702891,1702974,1702991,1703675,1703740,1704854,1704888,1705038,1705080,1705102,1705121,1705328,1705733,1706213
Modified: subversion/branches/1.9.x-patch-fixes/subversion/libsvn_client/patch.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x-patch-fixes/subversion/libsvn_client/patch.c?rev=1706555&r1=1706554&r2=1706555&view=diff
==============================================================================
--- subversion/branches/1.9.x-patch-fixes/subversion/libsvn_client/patch.c (original)
+++ subversion/branches/1.9.x-patch-fixes/subversion/libsvn_client/patch.c Sat Oct 3 11:53:20 2015
@@ -152,6 +152,9 @@ typedef struct prop_patch_target_t {
* ### Should we use flags instead since we're not using all enum values? */
svn_diff_operation_kind_t operation;
+ /* When true the property change won't be applied */
+ svn_boolean_t skipped;
+
/* ### Here we'll add flags telling if the prop was added, deleted,
* ### had_rejects, had_local_mods prior to patching and so on. */
} prop_patch_target_t;
@@ -2427,6 +2430,7 @@ apply_one_patch(patch_target_t **patch_t
hash_index = apr_hash_next(hash_index))
{
prop_patch_target_t *prop_target;
+ svn_boolean_t applied_one = FALSE;
prop_target = apr_hash_this_val(hash_index);
@@ -2445,24 +2449,30 @@ apply_one_patch(patch_target_t **patch_t
prop_target->name,
iterpool));
else
- SVN_ERR(apply_hunk(target, prop_target->content, hi,
- prop_target->name,
- iterpool));
+ {
+ SVN_ERR(apply_hunk(target, prop_target->content, hi,
+ prop_target->name,
+ iterpool));
+ applied_one = TRUE;
+ }
}
- if (prop_target->content->existed)
- {
- /* Copy any remaining lines to target. */
- SVN_ERR(copy_lines_to_target(prop_target->content, 0,
- scratch_pool));
- if (! prop_target->content->eof)
- {
- /* We could not copy the entire target property to the
- * temporary file, and would truncate the target if we
- * copied the temporary file on top of it. Skip this target. */
- target->skipped = TRUE;
- }
- }
+ if (!applied_one)
+ prop_target->skipped = TRUE;
+
+ if (applied_one && prop_target->content->existed)
+ {
+ /* Copy any remaining lines to target. */
+ SVN_ERR(copy_lines_to_target(prop_target->content, 0,
+ scratch_pool));
+ if (! prop_target->content->eof)
+ {
+ /* We could not copy the entire target property to the
+ * temporary file, and would truncate the target if we
+ * copied the temporary file on top of it. Skip this target. */
+ target->skipped = TRUE;
+ }
+ }
}
svn_pool_destroy(iterpool);
@@ -2876,6 +2886,9 @@ install_patched_prop_targets(patch_targe
if (ctx->cancel_func)
SVN_ERR(ctx->cancel_func(ctx->cancel_baton));
+ if (prop_target->skipped)
+ continue;
+
/* For a deleted prop we only set the value to NULL. */
if (prop_target->operation == svn_diff_op_deleted)
{
Modified: subversion/branches/1.9.x-patch-fixes/subversion/libsvn_diff/parse-diff.c
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x-patch-fixes/subversion/libsvn_diff/parse-diff.c?rev=1706555&r1=1706554&r2=1706555&view=diff
==============================================================================
--- subversion/branches/1.9.x-patch-fixes/subversion/libsvn_diff/parse-diff.c (original)
+++ subversion/branches/1.9.x-patch-fixes/subversion/libsvn_diff/parse-diff.c Sat Oct 3 11:53:20 2015
@@ -59,7 +59,7 @@ struct svn_diff__hunk_range {
struct svn_diff_hunk_t {
/* The patch this hunk belongs to. */
- svn_patch_t *patch;
+ const svn_patch_t *patch;
/* APR file handle to the patch file this hunk came from. */
apr_file_t *apr_file;
Modified: subversion/branches/1.9.x-patch-fixes/subversion/tests/cmdline/patch_tests.py
URL: http://svn.apache.org/viewvc/subversion/branches/1.9.x-patch-fixes/subversion/tests/cmdline/patch_tests.py?rev=1706555&r1=1706554&r2=1706555&view=diff
==============================================================================
--- subversion/branches/1.9.x-patch-fixes/subversion/tests/cmdline/patch_tests.py (original)
+++ subversion/branches/1.9.x-patch-fixes/subversion/tests/cmdline/patch_tests.py Sat Oct 3 11:53:20 2015
@@ -5691,6 +5691,187 @@ def patch_final_eol(sbox):
expected_status, expected_skip,
[], False, True, '--reverse-diff')
+def patch_prop_madness(sbox):
+ "patch property madness"
+
+ sbox.build()
+ wc_dir = sbox.wc_dir
+
+ sbox.simple_propset('mod_s', 'value\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_s_n', 'no-eol',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_l', 'this\nis\na\nvery\nvery\nlong\nvalue.\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_l_n', 'this\nis\na\nvery\nvery\nlong\nvalue.\n'
+ 'without\neol', # No eol at end
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('del', 'value\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('del_n', 'no-eol',
+ 'iota', 'A/mu')
+
+ sbox.simple_commit()
+
+ r2_props = {
+ 'mod_l_n' : 'this\nis\na\nvery\nvery\nlong\nvalue.\nwithout\neol',
+ 'mod_l' : 'this\nis\na\nvery\nvery\nlong\nvalue.\n',
+ 'mod_s' : 'value\n',
+ 'mod_s_n' : 'no-eol',
+ 'del' : 'value\n',
+ 'del_n' : 'no-eol',
+ }
+ expected_disk = svntest.main.greek_state.copy()
+ expected_disk.tweak('iota', 'A/mu', props=r2_props)
+
+ sbox.simple_propset('mod_s', 'other\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_s_n', 'still no eol',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_l', 'this\nis\na\nsomewhat\nlong\nvalue.\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('mod_l_n', 'this\nis\na\nanother\n..\nlong\nvalue.\n'
+ 'without\neol', # No eol at end
+ 'iota', 'A/mu')
+
+ sbox.simple_propdel('del', 'iota', 'A/mu')
+
+ sbox.simple_propdel('del_n', 'iota', 'A/mu')
+
+ sbox.simple_propset('add_s', 'new-value\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('add_s_n', 'new other no eol',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('add_l', 'this\nis\nsomething\n',
+ 'iota', 'A/mu')
+
+ sbox.simple_propset('add_l_n', 'this\nhas\nno\neol', # No eol at end
+ 'iota', 'A/mu')
+
+ _, output, _ = svntest.actions.run_and_verify_svn(None, [],
+ 'diff', wc_dir)
+
+ expected_status = svntest.actions.get_virginal_state(wc_dir, 1)
+
+ new_props = {
+ 'mod_s' : 'other\n',
+ 'mod_s_n' : 'still no eol',
+ 'mod_l' : 'this\nis\na\nsomewhat\nlong\nvalue.\n',
+ 'mod_l_n' : 'this\nis\na\nanother\n..\nlong\nvalue.\nwithout\neol',
+ 'add_s' : 'new-value\n',
+ 'add_s_n' : 'new other no eol',
+ 'add_l' : 'this\nis\nsomething\n',
+ 'add_l_n' : 'this\nhas\nno\neol'
+ }
+
+ expected_status.tweak('iota', 'A/mu', status=' M', wc_rev='2')
+ expected_disk.tweak('iota', 'A/mu', props=new_props)
+
+ svntest.actions.verify_disk(wc_dir, expected_disk, True)
+ #svntest.actions.run_and_verify_status(wc_dir, expected_status)
+
+ svntest.actions.run_and_verify_svn(None, [],
+ 'revert', wc_dir, '-R')
+
+ patch = sbox.get_tempname('patch')
+ svntest.main.file_write(patch, ''.join(output), mode='wb')
+
+ expected_output = wc.State(wc_dir, {
+ 'A/mu' : Item(status=' U'),
+ 'iota' : Item(status=' U'),
+ })
+ expected_skip= wc.State(wc_dir, {
+ })
+
+ strip_count = wc_dir.count(os.path.sep)+1
+
+ # Patch once
+ svntest.actions.run_and_verify_patch(wc_dir, patch,
+ expected_output, expected_disk,
+ expected_status, expected_skip,
+ [], True, True,
+ '--strip', strip_count)
+
+ # Patch again
+ expected_output.tweak('A/mu', 'iota', status=' G')
+ svntest.actions.run_and_verify_patch(wc_dir, patch,
+ expected_output, expected_disk,
+ expected_status, expected_skip,
+ [], True, True,
+ '--strip', strip_count)
+
+ # Reverse
+ expected_output.tweak('A/mu', 'iota', status=' U')
+ expected_disk.tweak('A/mu', 'iota', props=r2_props)
+ expected_status.tweak('A/mu', 'iota', status=' ')
+ svntest.actions.run_and_verify_patch(wc_dir, patch,
+ expected_output, expected_disk,
+ expected_status, expected_skip,
+ [], True, True,
+ '--reverse-diff',
+ '--strip', strip_count)
+
+ # And repeat
+ expected_output.tweak('A/mu', 'iota', status=' G')
+ svntest.actions.run_and_verify_patch(wc_dir, patch,
+ expected_output, expected_disk,
+ expected_status, expected_skip,
+ [], True, True,
+ '--reverse-diff',
+ '--strip', strip_count)
+
+ # Ok, and now introduce some conflicts
+
+ sbox.simple_propset('del', 'value', 'iota') # Wrong EOL
+ sbox.simple_propset('del_n', 'regeleinde\n', 'iota') # Wrong EOL+value
+
+ sbox.simple_propset('del', 'waarde', 'A/mu') # Wrong EOL+value
+ sbox.simple_propset('del_n', 'no-eol\n', 'A/mu') # Wrong EOL
+
+ expected_output.tweak('A/mu', 'iota', status=' C')
+ expected_status.tweak('iota', 'A/mu', status=' M')
+
+ iota_props = new_props.copy()
+ iota_props['del_n'] = 'regeleinde\n'
+ mu_props = new_props.copy()
+ mu_props['del'] = 'waarde'
+ expected_disk.tweak('iota', props=iota_props)
+ expected_disk.tweak('A/mu', props=mu_props)
+
+ expected_disk.add({
+ 'A/mu.svnpatch.rej' : Item(contents="--- %s\n"
+ "+++ %s\n"
+ "Property: del\n"
+ "## -1,1 +0,0 ##\n"
+ "-value\n"
+ % (sbox.path('A/mu'),
+ sbox.path('A/mu'))),
+ 'iota.svnpatch.rej' : Item(contents="--- %s\n"
+ "+++ %s\n"
+ "Property: del_n\n"
+ "## -1,1 +0,0 ##\n"
+ "-no-eol\n"
+ "\ No newline at end of property\n"
+ % (sbox.path('iota'),
+ sbox.path('iota'))),
+ })
+
+ svntest.actions.run_and_verify_patch(wc_dir, patch,
+ expected_output, expected_disk,
+ expected_status, expected_skip,
+ [], True, True,
+ '--strip', strip_count)
+
########################################################################
#Run the tests
@@ -5753,6 +5934,7 @@ test_list = [ None,
patch_delete_nodes,
patch_delete_missing_eol,
patch_final_eol,
+ patch_prop_madness,
]
if __name__ == '__main__':