You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by st...@icw.de on 2012/01/27 15:37:11 UTC
[jxpath] Converter Lookup within BasicTypeConverter
Hi,
I stumbled over the BasicTypeConverter
(org.apache.commons.jxpath.util.BasicTypeConverter.java)
Within this class the BeanUtils ConvertUtils class is used for looking up
a matching converter. This is done by only supplying the target class. I
think it is worthwhile to either change this to use the lookup method for
both source and target class as arguments (I have not tested whether this
would break something) or refactor that lookup call into a protected
method of BasicTypeConverter, which accepts source and target class and
the implementation of BasicTypeConverter giving as default implementation
the old behavior.
What do you think of that ?
By the way, when will 1.4 be released ?
Cheers,
Stefan Albrecht
InterComponentWare AG | Altrottstraße 31 | 69190 Walldorf (Baden) |
Germany
Tel.: +49 (0) 6227 385 246 | Fax: +49 (0) 6227 385 192
stefan.albrecht@icw.de | www.icw.de
InterComponentWare AG:
Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
Aufsichtsratsvors.: Prof. Dr. Christof Hettich
Firmensitz: 69190 Walldorf, Altrottstraße 31
AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [jxpath] Converter Lookup within BasicTypeConverter
Posted by Matt Benson <gu...@gmail.com>.
On Fri, Jan 27, 2012 at 8:37 AM, <st...@icw.de> wrote:
> Hi,
>
> I stumbled over the BasicTypeConverter
> (org.apache.commons.jxpath.util.BasicTypeConverter.java)
>
> Within this class the BeanUtils ConvertUtils class is used for looking up
> a matching converter. This is done by only supplying the target class. I
> think it is worthwhile to either change this to use the lookup method for
> both source and target class as arguments (I have not tested whether this
> would break something) or refactor that lookup call into a protected
> method of BasicTypeConverter, which accepts source and target class and
> the implementation of BasicTypeConverter giving as default implementation
> the old behavior.
>
> What do you think of that ?
Hi, Stefan. I haven't looked directly at the code you mention, but
what you're describing sounds reasonable, yes. :)
> By the way, when will 1.4 be released ?
Excellent question. I've recently done a little bit of work on JXPath
and am hoping to make a release in the near future, perhaps in
February or March?
Thanks for your interest,
Matt
>
> Cheers,
> Stefan Albrecht
>
> InterComponentWare AG | Altrottstraße 31 | 69190 Walldorf (Baden) |
> Germany
> Tel.: +49 (0) 6227 385 246 | Fax: +49 (0) 6227 385 192
> stefan.albrecht@icw.de | www.icw.de
>
>
>
>
>
>
> InterComponentWare AG:
> Vorstand: Peter Kirschbauer (Vors.), Jörg Stadler
> Aufsichtsratsvors.: Prof. Dr. Christof Hettich
> Firmensitz: 69190 Walldorf, Altrottstraße 31
> AG Mannheim HRB 351761 / USt.-IdNr.: DE 198388516
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org