You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2012/09/30 11:57:07 UTC
[jira] [Created] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Claus Ibsen created CAMEL-5668:
----------------------------------
Summary: camel-jetty - A soap fault should trigger http response code 500
Key: CAMEL-5668
URL: https://issues.apache.org/jira/browse/CAMEL-5668
Project: Camel
Issue Type: Bug
Components: camel-jetty
Affects Versions: 2.10.0, 2.9.0
Reporter: Claus Ibsen
Priority: Minor
Fix For: 2.9.4, 2.11.0, 2.10.2
See nabble
http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-5668.
---------------------------------
Resolution: Fixed
Applied the patch into trunk, camel-2.10.x and camel-2.9.x branches.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466620#comment-13466620 ]
Willem Jiang commented on CAMEL-5668:
-------------------------------------
Applied the patch with thanks to James, I also fix the test errors of camel-jetty caused by this change.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467024#comment-13467024 ]
James Carman commented on CAMEL-5668:
-------------------------------------
Sorry about introducing the test failure. I saw that late last night and didn't have time to fix it.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466609#comment-13466609 ]
James Carman commented on CAMEL-5668:
-------------------------------------
I believe this is reported against the wrong component. The issue actually lies within the HTTP component in the DefaultHttpBinding class.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-5668:
-----------------------------------
Assignee: Willem Jiang
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated CAMEL-5668:
--------------------------------
Attachment: (was: CAMEL-5668.patch)
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated CAMEL-5668:
--------------------------------
Attachment: CAMEL-5668.patch
Here's a patch that implements what I think you're looking for. I should probably add a test in the http component also, since that's where the actual code change takes place.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466616#comment-13466616 ]
James Carman commented on CAMEL-5668:
-------------------------------------
We should really think about consolidating this code. There are some value-adds in the http component that aren't in the http4 component. They're virtually the same exact code. There has to be a way to extract a superclass from this and create some abstract supermodule that they can both reference.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466617#comment-13466617 ]
Willem Jiang commented on CAMEL-5668:
-------------------------------------
@James,
Yes, we need to share these code in a common http module to avoid updating the code in camel-http and camel-http4 modules.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-5668) camel-jetty - A soap fault should
trigger http response code 500
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated CAMEL-5668:
--------------------------------
Attachment: CAMEL-5668.patch
Here's another patch that patches both the http and http4 components.
> camel-jetty - A soap fault should trigger http response code 500
> ----------------------------------------------------------------
>
> Key: CAMEL-5668
> URL: https://issues.apache.org/jira/browse/CAMEL-5668
> Project: Camel
> Issue Type: Bug
> Components: camel-jetty
> Affects Versions: 2.9.0, 2.10.0
> Reporter: Claus Ibsen
> Assignee: Willem Jiang
> Priority: Minor
> Fix For: 2.9.4, 2.11.0, 2.10.2
>
> Attachments: CAMEL-5668.patch
>
>
> See nabble
> http://camel.465427.n5.nabble.com/Help-with-nmr-cxf-endpoints-and-fault-handling-tp5719720.html
> If a response is fault=true, then we should force the http response code to be 500. Which is what the SOAP 1.1 spec mandates.
> See section 6.2 at: http://www.w3.org/TR/soap11/#_Ref477795996
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira