[GitHub] [incubator-doris] morningman opened a new pull request #5230: [Bug][Clone]

[GitBox <gi...@apache.org>]

morningman opened a new pull request #5230:
URL: https://github.com/apache/incubator-doris/pull/5230


   ## Proposed changes
   
   In version 0.13, we support a more efficient compaction logic. 
   This logic will maintain multiple version paths of the tablet.
   This can avoid -230 errors and can also support incremental clone.
   
   But the previous incremental clone uses the incremental rowset meta recorded in `incr_rs_meta`.
   At present, the incremental rowset meta recorded in `incr_rs_meta` and the records
   in `stale_rs_meta` are duplicated, and the current clone logic does not adapt to the
   new multi-version path, resulting in many cases not triggering incremental clone.
   
   This CL mainly modified:
   
   1. Removed `incr_rs_meta` metadata
   2. Modified the clone logic. When the clone is incremented, it will try to read the rowset in `stale_rs_meta`.
   3. Delete a lot of code that was previously used for version compatibility.
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [] Bugfix (non-breaking change which fixes an issue)
   - [] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [] Documentation Update (if none of the other choices apply)
   - [] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
   - [] Compiling and unit tests pass locally with my changes
   - [] I have added tests that prove my fix is effective or that my feature works
   - [] If this change need a document change, I have updated the document
   - [] Any dependent changes have been merged
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #5230: [Bug][Clone] Fix the bug that incremental clone is not triggered

[GitBox <gi...@apache.org>]

morningman merged pull request #5230:
URL: https://github.com/apache/incubator-doris/pull/5230


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org