You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/03/15 14:09:04 UTC
[PR] [SPARK-44740][CONNECT][TESTS][FOLLOWUP] Deduplicate `test_metadata` [spark]
zhengruifeng opened a new pull request, #45535:
URL: https://github.com/apache/spark/pull/45535
### What changes were proposed in this pull request?
Deduplicate `test_metadata`
https://github.com/apache/spark/commit/576d1698c7b52b2d9ce00fa2fc5912c92e8bbe67 added a test with duplicated name `test_metadata`, so one of the two was skipped.
### Why are the changes needed?
manually check
before
```
grep test_metadata /Users/ruifeng.zheng/Dev/spark/python/target/9b1b140e-ad38-4e53-acae-031c152f2a42/python3__pyspark.sql.tests.connect.test_connect_session__55w2s1pn.log
test_metadata (pyspark.sql.tests.connect.test_connect_session.ChannelBuilderTests.test_metadata) ... ok (0.000s)
```
after
```
grep test_metadata /Users/ruifeng.zheng/Dev/spark/python/target/79d78590-7275-480f-adc4-1acecc2c61de/python3__pyspark.sql.tests.connect.test_connect_session__4ei_cczz.log
test_metadata (pyspark.sql.tests.connect.test_connect_session.ChannelBuilderTests.test_metadata) ... ok (0.000s)
test_metadata_with_session_id (pyspark.sql.tests.connect.test_connect_session.ChannelBuilderTests.test_metadata_with_session_id) ... ok (0.000s)
```
### Does this PR introduce _any_ user-facing change?
no, test only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44740][CONNECT][TESTS][FOLLOWUP] Deduplicate `test_metadata` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45535: [SPARK-44740][CONNECT][TESTS][FOLLOWUP] Deduplicate `test_metadata`
URL: https://github.com/apache/spark/pull/45535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44740][CONNECT][TESTS][FOLLOWUP] Deduplicate `test_metadata` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45535:
URL: https://github.com/apache/spark/pull/45535#issuecomment-1999990266
Oh my bad.
To @zhengruifeng , we cannot make a followup for the released JIRA issue.
Please use a new JIRA next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44740][CONNECT][TESTS][FOLLOWUP] Deduplicate `test_metadata` [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #45535:
URL: https://github.com/apache/spark/pull/45535#issuecomment-2002714575
ah, sorry, I ignored this.
will be carefully next time @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org