You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/03/28 22:27:57 UTC
Review Request 58009: Fetching running application logs results in
'java.io.IOException'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Bugs: AMBARI-20612
https://issues.apache.org/jira/browse/AMBARI-20612
Repository: ambari
Description
-------
A new property called yarn.log.server.web-service.url was added in HDP 2.6
It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
Fix is to provide the upgrade packs for it.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e4
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/58009/diff/1/
Testing
-------
HDP upgrade from 2.5->2.6
Unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/#review170349
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Lines 33 (patched)
<https://reviews.apache.org/r/58009/#comment243162>
Remove this type of comment and add a description of what it does.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Lines 45 (patched)
<https://reviews.apache.org/r/58009/#comment243163>
Nitpick put some newline before Inject, Override, and function signature
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Lines 61 (patched)
<https://reviews.apache.org/r/58009/#comment243164>
Shouldn't policy be required?
Can first check its value before checking the other properties.
And if the value is http, then yarn.timeline-service.webapp.address is required, otherwise, then yarn.timeline-service.webapp.https.address is required.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Lines 67 (patched)
<https://reviews.apache.org/r/58009/#comment243165>
Spaces before and after braces, and after commas
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml
Lines 745 (patched)
<https://reviews.apache.org/r/58009/#comment243161>
YARN with all caps
- Alejandro Fernandez
On March 28, 2017, 10:27 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58009/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 10:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20612
> https://issues.apache.org/jira/browse/AMBARI-20612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new property called yarn.log.server.web-service.url was added in HDP 2.6
> It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
> The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
> Fix is to provide the upgrade packs for it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e4
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58009/diff/1/
>
>
> Testing
> -------
>
> HDP upgrade from 2.5->2.6
> Unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/#review170351
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Line 57 (original), 64 (patched)
<https://reviews.apache.org/r/58009/#comment243167>
Only retrieve one of these after the policy is not null and we know which one is needed.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java
Line 66 (original), 73 (patched)
<https://reviews.apache.org/r/58009/#comment243168>
Nitpick, you can change your edit to insert spaces between if and "("
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java
Line 298 (original), 298 (patched)
<https://reviews.apache.org/r/58009/#comment243169>
Spaces after + and ,
- Alejandro Fernandez
On March 29, 2017, 12:06 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58009/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 12:06 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20612
> https://issues.apache.org/jira/browse/AMBARI-20612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new property called yarn.log.server.web-service.url was added in HDP 2.6
> It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
> The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
> Fix is to provide the upgrade packs for it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58009/diff/2/
>
>
> Testing
> -------
>
> HDP upgrade from 2.5->2.6
> Unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/#review170352
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 29, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58009/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20612
> https://issues.apache.org/jira/browse/AMBARI-20612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new property called yarn.log.server.web-service.url was added in HDP 2.6
> It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
> The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
> Fix is to provide the upgrade packs for it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58009/diff/3/
>
>
> Testing
> -------
>
> HDP upgrade from 2.5->2.6
> Unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/#review170356
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On March 29, 2017, 12:20 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58009/
> -----------------------------------------------------------
>
> (Updated March 29, 2017, 12:20 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
>
>
> Bugs: AMBARI-20612
> https://issues.apache.org/jira/browse/AMBARI-20612
>
>
> Repository: ambari
>
>
> Description
> -------
>
> A new property called yarn.log.server.web-service.url was added in HDP 2.6
> It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
> The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
> Fix is to provide the upgrade packs for it.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/58009/diff/3/
>
>
> Testing
> -------
>
> HDP upgrade from 2.5->2.6
> Unit tests
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/
-----------------------------------------------------------
(Updated March 29, 2017, 12:20 a.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Changes
-------
Review comments
Bugs: AMBARI-20612
https://issues.apache.org/jira/browse/AMBARI-20612
Repository: ambari
Description
-------
A new property called yarn.log.server.web-service.url was added in HDP 2.6
It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
Fix is to provide the upgrade packs for it.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/58009/diff/3/
Changes: https://reviews.apache.org/r/58009/diff/2-3/
Testing
-------
HDP upgrade from 2.5->2.6
Unit tests
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 58009: Fetching running application logs results in
'java.io.IOException'
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58009/
-----------------------------------------------------------
(Updated March 29, 2017, 12:06 a.m.)
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty.
Changes
-------
Incorporated review comments
Bugs: AMBARI-20612
https://issues.apache.org/jira/browse/AMBARI-20612
Repository: ambari
Description
-------
A new property called yarn.log.server.web-service.url was added in HDP 2.6
It takes value from yarn.timeline-service.webapp.address if the yarn.http.policy is HTTP_ONLY and takes value from yarn.timeline-service.webapp.https.address if the yarn.http.policy is HTTPS_ONLY.
The logic works on fresh installs but is not present during upgrades from HDP2.x to HDP2.6
Fix is to provide the upgrade packs for it.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrl.java PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml c8f93e436f
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml 3c0769a720
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 53caa52c6b
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 66f1a64d9d
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml 0d6f51b2e1
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 44d0a2a1d9
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixYarnWebServiceUrlTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/58009/diff/2/
Changes: https://reviews.apache.org/r/58009/diff/1-2/
Testing
-------
HDP upgrade from 2.5->2.6
Unit tests
Thanks,
Madhuvanthi Radhakrishnan