[jira] Commented: (MRELEASE-295) Internal dependencies left at old snapshot

["Samuli Saarinen (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MRELEASE-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=150204#action_150204 ] 

Samuli Saarinen commented on MRELEASE-295:
------------------------------------------

Test that should cover this is imho configured wrong. In AbstractRewritingReleasePhaseTestCase.testRewritePomDependencies() reactor projects are created from poms in rewrite-for-development/internal-snapshot-dependencies directory. Test pom files that are used to create the projects have versions without -SNAPSHOT attached to them although when releasing an actual project the reactor projects have -SNAPSHOT attached to versions. This could affect to all the test cases that uses pom files from rewrite-for-development directory.

I'll attach a patch to change the pom's so that the test will fail if it helps to solve this issue.

> Internal dependencies left at old snapshot
> ------------------------------------------
>
>                 Key: MRELEASE-295
>                 URL: http://jira.codehaus.org/browse/MRELEASE-295
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-6
>            Reporter: Chris Searle
>         Attachments: release_test.zip
>
>
> I'm having a problem with version numbering when releasing a given reactor with modules within the reactor that have dependencies inside the reactor.
> I have narrowed this to the following structure
> A parent test/pom.xml (basically a pom packging grouping pom - but here is where the scm and repos are also defined) with
>   <groupId>test</groupId>
>   <artifactId>test</artifactId>
>   <packaging>pom</packaging>
>   <version>1.0-SNAPSHOT</version>
> and
>   <modules>
>     <module>test-1</module>
>     <module>test-2</module>
>   </modules>
> Then - the two modules:
> test/test-1/pom.xml with
>   <parent>
>     <groupId>test</groupId>
>     <artifactId>test</artifactId>
>     <version>1.0-SNAPSHOT</version>
>   </parent>
>   <groupId>test</groupId>
>   <artifactId>test-1</artifactId>
>   <version>1.0-SNAPSHOT</version>
> test/test-2/pom.xml with
>   <parent>
>     <groupId>test</groupId>
>     <artifactId>test</artifactId>
>     <version>1.0-SNAPSHOT</version>
>   </parent>
>   <groupId>test</groupId>
>   <artifactId>test-2</artifactId>
>   <version>1.0-SNAPSHOT</version>
>   <dependencies>
>     <dependency>
>       <groupId>test</groupId>
>       <artifactId>test-1</artifactId>
>       <version>1.0-SNAPSHOT</version>
>     </dependency>
>   </dependencies>
> Then run mvn -DdryRun=true release:prepare
> test/pom.xml.tag version=1.0 - good
> test/pom.xml.next version=1.1-SNAPSHOT - good
> test-1/pom.xml.tag version=1.0, parent version=1.0 good
> test-1/pom.xml.next version=1.1-SNAPSHOT, parent version=1.1-SNAPSHOT - good
> test-2/pom.xml.tag version=1.0, parent version=1.0, dependency to test-1 version=1.0 good
> test-2/pom.xml.next version=1.1-SNAPSHOT, parent version=1.1-SNAPSHOT - good
> BUT
> test-2/pom.xml.next dependency to test-1 version=1.0-SNAPSHOT
> This seems wrong to me - I would expect it to also get 1.1-SNAPSHOT for the dependency on test-1 since it has the same parent and is being run in the same reactor.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira