You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2014/07/03 18:21:01 UTC
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/53
TAJO-902: Unicode delimiter does not work correctly
I've verified TajoCli, TajoDump
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-902
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 0905851881ee8ce4e04b5005c81e05ec5ff3a13a
Author: jinossy <ji...@gmail.com>
Date: 2014-07-03T16:16:47Z
TAJO-902: Unicode delimiter does not work correctly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/53#issuecomment-48136259
Do we need to change the documentation?
http://tajo.apache.org/docs/current/table_management/csv.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/53#issuecomment-48137212
No, we don't need
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/53#issuecomment-48139546
+1
Sounds nice. The patch looks good to me. I leave one comment. Before you commit it, please add a brief explanation about the condition. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-902: Unicode delimiter does not work corre...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/53#discussion_r14581009
--- Diff: tajo-client/src/main/java/org/apache/tajo/cli/DescTableCommand.java ---
@@ -84,8 +86,13 @@ protected String toFormattedString(TableDesc desc) {
}
sb.append("Options: \n");
for(Map.Entry<String, String> entry : desc.getMeta().toMap().entrySet()){
+ String value = entry.getValue();
+ String unescaped = StringEscapeUtils.unescapeJava(value);
+ if(unescaped.length() == 1 && CharUtils.isAsciiPrintable(unescaped.charAt(0))){
--- End diff --
Could you add some comment about the purpose of this condition?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---