You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrei Sekretenko (Jira)" <ji...@apache.org> on 2020/11/03 14:30:00 UTC

[jira] [Commented] (MESOS-10176) Add validation of roles in the offer constraints

    [ https://issues.apache.org/jira/browse/MESOS-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225459#comment-17225459 ] 

Andrei Sekretenko commented on MESOS-10176:
-------------------------------------------

{noformat}
commit 4150559ab29e37c8b5d65024ce3a728b359de2f1
Author: Andrei Sekretenko <as...@apache.org>
Date:   Wed Oct 14 17:46:46 2020 +0200

    Moved failover timeout validation to stateless FrameworkInfo validation.
    
    This turns the validation of the failover timeout in `FrameworkInfo`
    into  a part of `validation::framework::validate()` that performs
    all the other validations that depend on `FrameworkInfo` only.
    
    Review: https://reviews.apache.org/r/72964

commit 3fcc148d5d28405f4256e4cfa7005786de10b4f9
Author: Andrei Sekretenko <as...@apache.org>
Date:   Mon Oct 12 20:47:01 2020 +0200

    Consolidated creation and validation of `allocator::Framework` options.
    
    This merges three near-identical pieces of scattered code in SUBSCRIBE
    and UPDATE_FRAMEWORK execution paths in the Master that validate
    and construct parts of `allocator::FrameworkOptions` (the set of
    suppressed roles and the offer constraints filter) into a single
    function.
    
    This is a prerequisite to adding validation of offer constraint roles.
    
    Review: https://reviews.apache.org/r/72955

commit c1e716054d8dead61074c8619ffa7b33f3064152 (HEAD -> master, origin/master, origin/HEAD, ci/asekretenko/offer_constraints_role_validation_backup)
Author: Andrei Sekretenko <as...@apache.org>
Date:   Mon Oct 12 22:06:51 2020 +0200

    Added validation that offer constraints are set only for existing roles.
    
    This patch makes SUBSCRIBE/UPDATE_FRAMEWORK calls validate that
    the framework does not specify offer constraints for roles to which
    it is not going to be subscribed.
    
    Review: https://reviews.apache.org/r/72956
{noformat}

> Add validation of roles in the offer constraints
> ------------------------------------------------
>
>                 Key: MESOS-10176
>                 URL: https://issues.apache.org/jira/browse/MESOS-10176
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Andrei Sekretenko
>            Assignee: Andrei Sekretenko
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)