You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficcontrol.apache.org by Dan Kirkwood <da...@apache.org> on 2016/12/05 22:48:49 UTC
Apache license in source files
Hi all.. We haven't really established a process for this, but to
keep in compliance with Apache license guidelines, each source file
should have the Apache license comment -- normally at the head of the
file, but I think that's somewhat flexible.
Still going thru files adding them, but when any new files get added,
they really should have that header in them already.
What do you all think of establishing a guideline that any PR is not
merged until the license is present in each source file added?
-dan
Re: Apache license in source files
Posted by Dan Kirkwood <da...@apache.org>.
Hey, Dave.. no finger pointing here.. We hadn't established any
guidelines yet, so figured it was time to bring it up...
I had a PR myself yesterday that did the same thing...
We're getting there!!
-dan
On Mon, Dec 5, 2016 at 4:22 PM, David Neuman <da...@gmail.com> wrote:
> +1 and sorry for merging a PR without. I will make sure all files have them
> before merging in the future.
>
> On Mon, Dec 5, 2016 at 15:48 Dan Kirkwood <da...@apache.org> wrote:
>
>> Hi all.. We haven't really established a process for this, but to
>> keep in compliance with Apache license guidelines, each source file
>> should have the Apache license comment -- normally at the head of the
>> file, but I think that's somewhat flexible.
>>
>> Still going thru files adding them, but when any new files get added,
>> they really should have that header in them already.
>>
>> What do you all think of establishing a guideline that any PR is not
>> merged until the license is present in each source file added?
>>
>> -dan
>>
Re: Apache license in source files
Posted by David Neuman <da...@gmail.com>.
+1 and sorry for merging a PR without. I will make sure all files have them
before merging in the future.
On Mon, Dec 5, 2016 at 15:48 Dan Kirkwood <da...@apache.org> wrote:
> Hi all.. We haven't really established a process for this, but to
> keep in compliance with Apache license guidelines, each source file
> should have the Apache license comment -- normally at the head of the
> file, but I think that's somewhat flexible.
>
> Still going thru files adding them, but when any new files get added,
> they really should have that header in them already.
>
> What do you all think of establishing a guideline that any PR is not
> merged until the license is present in each source file added?
>
> -dan
>
Re: Apache license in source files
Posted by Dan Kirkwood <da...@gmail.com>.
Hi Leif,
There's a .rat-excludes in the PR I posted today
(https://github.com/apache/incubator-trafficcontrol/pull/121) -- I'm
sure it's too liberal, but wanted to make sure we don't go backward..
-dan
On Mon, Dec 5, 2016 at 5:08 PM, Leif Hedstrom <zw...@apache.org> wrote:
>
>> On Dec 5, 2016, at 3:48 PM, Dan Kirkwood <da...@apache.org> wrote:
>>
>> Hi all.. We haven't really established a process for this, but to
>> keep in compliance with Apache license guidelines, each source file
>> should have the Apache license comment -- normally at the head of the
>> file, but I think that's somewhat flexible.
>>
>> Still going thru files adding them, but when any new files get added,
>> they really should have that header in them already.
>>
>> What do you all think of establishing a guideline that any PR is not
>> merged until the license is present in each source file added?
>
>
> Very much +1. There are exceptions, at which point you would add them to the RAT exclude file, but use that as sparingly as possible :).
>
> — Leif
>
>>
>> -dan
>
Re: Apache license in source files
Posted by Leif Hedstrom <zw...@apache.org>.
> On Dec 5, 2016, at 3:48 PM, Dan Kirkwood <da...@apache.org> wrote:
>
> Hi all.. We haven't really established a process for this, but to
> keep in compliance with Apache license guidelines, each source file
> should have the Apache license comment -- normally at the head of the
> file, but I think that's somewhat flexible.
>
> Still going thru files adding them, but when any new files get added,
> they really should have that header in them already.
>
> What do you all think of establishing a guideline that any PR is not
> merged until the license is present in each source file added?
Very much +1. There are exceptions, at which point you would add them to the RAT exclude file, but use that as sparingly as possible :).
— Leif
>
> -dan