You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/21 09:11:58 UTC

[GitHub] [skywalking] gaoweijie opened a new issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

gaoweijie opened a new issue #7146:
URL: https://github.com/apache/skywalking/issues/7146


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ ] Question or discussion
   
   ___
   ### Question
   - Why skywalking need add a new  ‘_$EnhancedClassField_ws’ filed into origin source class when skywalking do enhance logic.
   Is there any potential such risk about this logic? For example as below:
         When the business code takes out all the fields of a class (which has been enhanced by bytecode) through reflection for processing, it will also take out '_$EnhancedClassField_ws'  field for logical processing, which will cause problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864876712






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864947886


   > You need a class level cache to hold the context for instrumentation. Otherwise, you have to resolve the context every time, which is a big performance issue.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7146:
URL: https://github.com/apache/skywalking/issues/7146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864930905


   I carefully read the source code of springmvc, still have a little incomprehensible.
   Can you give me some explanation or inspiration.
   Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864875485






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #7146:
URL: https://github.com/apache/skywalking/issues/7146


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864876712


   > If you look at the source codes of plugin, such as popular SpringMVC, you will see why we need that.
   
   OK, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864934339


   You need a class level cache to hold the context for instrumentation. Otherwise, you have to resolve the context every time, which is a big performance issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864875485


   Your question is very hard to answer. In any case, with any form, you could say adding codes always have a bug. So, from a tech perspective, the answer would only have to be YES. There is a risk.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864875931


   If you look at the source codes of plugin, such as popular SpringMVC, you will see why we need that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie edited a comment on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie edited a comment on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864930905


   I carefully read the source code of springmvc, still have a little incomprehensible about '$EnhancedClassField_ws' field's reson and purpose.
   Can you give me some explanation or inspiration.
   Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] gaoweijie edited a comment on issue #7146: Why skywalking need add a new ‘_$EnhancedClassField_ws’ filed and Is there any potential such risk?

Posted by GitBox <gi...@apache.org>.
gaoweijie edited a comment on issue #7146:
URL: https://github.com/apache/skywalking/issues/7146#issuecomment-864930905


   I carefully read the source code of springmvc, still have a little incomprehensible about '$EnhancedClassField_ws' field's reson and purpose.
   Can you give me some explanation or inspiration.
   Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org