You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Radhika PC <ra...@citrix.com> on 2013/01/15 08:00:23 UTC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 7 a.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Changes
-------
Realized that this review item has the following feature documentation as well:
enable L4-L7 network services in the shared network in the advanced zone
Summary (updated)
-----------------
Documentation for the new features: Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in the shared network in the advanced zone, and User-provided hostname in vCenter
Description
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Diffs
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review19632
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika PC
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review19633
-----------------------------------------------------------
Ship it!
Ship It!
- Radhika PC
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy/ to the current code, I do not see it in 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving to 4.2.0." I have emailed Murali to ask the status of these features.
Once i get the confirmation from Murali, i will resubmit the patch
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review16162
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Animesh Chaturvedi <an...@citrix.com>.
Ok so if content looks good can one of the committer apply patch to master and close this review
> -----Original Message-----
> From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of Radhika
> PC
> Sent: Thursday, February 07, 2013 12:24 AM
> To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy;
> Jessica Tomechak
> Cc: Radhika Puthiyetath; cloudstack
> Subject: Re: Review Request: Documentation for the new features: Optional
> Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in
> the shared network in the advanced zone, and User-provided hostname in
> vCenter
>
>
>
> > On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP
> clearance 1/30, but comparing the proposed code at
> http://people.apache.org/~muralireddy/ to the current code, I do not see it in
> 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP
> clearance 1/30, but comparing the proposed code at
> http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or
> master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See
> Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving
> to 4.2.0." I have emailed Murali to ask the status of these features.
> >
> > Radhika PC wrote:
> > Once i get the confirmation from Murali, i will resubmit the
> > patch
>
> This patch is applicable only for 4.2 as patch for both bugs 312, 265 did not go
> in to 4.1. Confirmed with Murali.
>
>
> - Radhika
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/#review16162
> -----------------------------------------------------------
>
>
> On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8180/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 15, 2013, 12:34 p.m.)
> >
> >
> > Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra
> Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
> >
> >
> > Description
> > -------
> >
> > This review request is for the documentation written for the following
> features:
> >
> > Optional Public IP assignment for EIP with Basic Zone User-provided
> > host name in vCenter Enable L4-L7 network services in the shared
> > network in the advanced zone
> >
> >
> > Diffs
> > -----
> >
> > docs/en-US/Installation_Guide.xml 2f60aca
> > docs/en-US/about-working-with-vms.xml 47153e2
> > docs/en-US/append-displayname-vms.xml PRE-CREATION
> > docs/en-US/creating-network-offerings.xml ab56920
> > docs/en-US/elastic-ip.xml PRE-CREATION
> > docs/en-US/network-offerings.xml c1fd79d
> > docs/en-US/networks.xml a7b9ea1
> > docs/en-US/set-up-network-for-users.xml 2b40923
> > docs/en-US/using-multiple-guest-networks.xml 9076a81
> > docs/en-US/using-netscaler-load-balancers.xml c2044de
> > docs/en-US/virtual-machines.xml 7c74932
> >
> > Diff: https://reviews.apache.org/r/8180/diff/
> >
> >
> > Testing
> > -------
> >
> > Patch cleanly applies. doc is reviewed by QA
> >
> >
> > Thanks,
> >
> > Radhika PC
> >
> >
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy/ to the current code, I do not see it in 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving to 4.2.0." I have emailed Murali to ask the status of these features.
>
> Radhika PC wrote:
> Once i get the confirmation from Murali, i will resubmit the patch
This patch is applicable only for 4.2 as patch for both bugs 312, 265 did not go in to 4.1. Confirmed with Murali.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review16162
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Radhika Puthiyetath <ra...@citrix.com>.
This is very much relevant! Nobody pushed ii for some reasons, and now some of the files in the patch is overwritten, and I need to submit a new patch based on latest files.
I am currently busy with 4.1 features. Once I am through with this , I shall update the diff .
-----Original Message-----
From: Animesh Chaturvedi
Sent: Thursday, February 21, 2013 5:02 AM
To: cloudstack-dev@incubator.apache.org; Radhika Puthiyetath; Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy; Jessica Tomechak
Subject: RE: Review Request: Documentation for the new features: Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in the shared network in the advanced zone, and User-provided hostname in vCenter
Radhika
Is this patch still relevant? If not please discard and submit a new patch
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:54 AM
> To: cloudstack-dev@incubator.apache.org; Radhika Puthiyetath; Chip
> Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy;
> Jessica Tomechak
> Subject: RE: Review Request: Documentation for the new features:
> Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7
> network services in the shared network in the advanced zone, and
> User-provided hostname in vCenter
>
> > -----Original Message-----
> > From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of
> > Radhika PC
> > Sent: Thursday, February 14, 2013 7:42 AM
> > To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali
> > Reddy; Jessica Tomechak
> > Cc: Radhika Puthiyetath; cloudstack
> > Subject: Re: Review Request: Documentation for the new features:
> > Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7
> > network services in the shared network in the advanced zone, and
> > User-provided hostname in vCenter
> >
> >
> >
> > > On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > > > CLOUDSTACK-265, optional public IP for EIP with basic zone:
> > > > passed IP
> > clearance 1/30, but comparing the proposed code at
> > http://people.apache.org/~muralireddy/ to the current code, I do not
> > see it in
> > 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services:
> > passed IP clearance 1/30, but comparing the proposed code at
> > http://people.apache.org/~muralireddy to the repo, I do not see it
> > in
> > 4.1 or master branches. CLOUDSTACK-778, user-provided hostname,
> > isn't in 4.1. See Vijay B's comment in the bug today: "The patch
> > didn't make it to 4.1.0. Moving to 4.2.0." I have emailed Murali to
> > ask the status of these
> features.
> > >
> > > Radhika PC wrote:
> > > Once i get the confirmation from Murali, i will resubmit the
> > > patch
> > >
> > > Radhika PC wrote:
> > > This patch is applicable only for 4.2 as patch for both bugs
> > > 312, 265 did not
> > go in to 4.1. Confirmed with Murali.
> >
> > since creating-network-offering.xml file has been changed now with
> > persistent network patch, I shall submit a new patch for this.
> >
> >
> [Animesh>] Radhika so is this patch not relevant anymore? If so please
> discard it
> > - Radhika
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8180/#review16162
> > -----------------------------------------------------------
> >
> >
> > On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/8180/
> > > -----------------------------------------------------------
> > >
> > > (Updated Jan. 15, 2013, 12:34 p.m.)
> > >
> > >
> > > Review request for cloudstack, Chip Childers, Venkata Siva
> > > Vijayendra
> > Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
> > >
> > >
> > > Description
> > > -------
> > >
> > > This review request is for the documentation written for the
> > > following
> > features:
> > >
> > > Optional Public IP assignment for EIP with Basic Zone
> > > User-provided host name in vCenter Enable L4-L7 network services
> > > in the shared network in the advanced zone
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > docs/en-US/Installation_Guide.xml 2f60aca
> > > docs/en-US/about-working-with-vms.xml 47153e2
> > > docs/en-US/append-displayname-vms.xml PRE-CREATION
> > > docs/en-US/creating-network-offerings.xml ab56920
> > > docs/en-US/elastic-ip.xml PRE-CREATION
> > > docs/en-US/network-offerings.xml c1fd79d
> > > docs/en-US/networks.xml a7b9ea1
> > > docs/en-US/set-up-network-for-users.xml 2b40923
> > > docs/en-US/using-multiple-guest-networks.xml 9076a81
> > > docs/en-US/using-netscaler-load-balancers.xml c2044de
> > > docs/en-US/virtual-machines.xml 7c74932
> > >
> > > Diff: https://reviews.apache.org/r/8180/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > Patch cleanly applies. doc is reviewed by QA
> > >
> > >
> > > Thanks,
> > >
> > > Radhika PC
> > >
> > >
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Animesh Chaturvedi <an...@citrix.com>.
Radhika
Is this patch still relevant? If not please discard and submit a new patch
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:54 AM
> To: cloudstack-dev@incubator.apache.org; Radhika Puthiyetath; Chip Childers;
> Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy; Jessica Tomechak
> Subject: RE: Review Request: Documentation for the new features: Optional
> Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in
> the shared network in the advanced zone, and User-provided hostname in
> vCenter
>
> > -----Original Message-----
> > From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of
> > Radhika PC
> > Sent: Thursday, February 14, 2013 7:42 AM
> > To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali
> > Reddy; Jessica Tomechak
> > Cc: Radhika Puthiyetath; cloudstack
> > Subject: Re: Review Request: Documentation for the new features:
> > Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7
> > network services in the shared network in the advanced zone, and
> > User-provided hostname in vCenter
> >
> >
> >
> > > On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > > > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed
> > > > IP
> > clearance 1/30, but comparing the proposed code at
> > http://people.apache.org/~muralireddy/ to the current code, I do not
> > see it in
> > 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed
> > IP clearance 1/30, but comparing the proposed code at
> > http://people.apache.org/~muralireddy to the repo, I do not see it in
> > 4.1 or master branches. CLOUDSTACK-778, user-provided hostname, isn't
> > in 4.1. See Vijay B's comment in the bug today: "The patch didn't make
> > it to 4.1.0. Moving to 4.2.0." I have emailed Murali to ask the status of these
> features.
> > >
> > > Radhika PC wrote:
> > > Once i get the confirmation from Murali, i will resubmit the
> > > patch
> > >
> > > Radhika PC wrote:
> > > This patch is applicable only for 4.2 as patch for both bugs
> > > 312, 265 did not
> > go in to 4.1. Confirmed with Murali.
> >
> > since creating-network-offering.xml file has been changed now with
> > persistent network patch, I shall submit a new patch for this.
> >
> >
> [Animesh>] Radhika so is this patch not relevant anymore? If so please discard
> it
> > - Radhika
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8180/#review16162
> > -----------------------------------------------------------
> >
> >
> > On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/8180/
> > > -----------------------------------------------------------
> > >
> > > (Updated Jan. 15, 2013, 12:34 p.m.)
> > >
> > >
> > > Review request for cloudstack, Chip Childers, Venkata Siva
> > > Vijayendra
> > Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
> > >
> > >
> > > Description
> > > -------
> > >
> > > This review request is for the documentation written for the
> > > following
> > features:
> > >
> > > Optional Public IP assignment for EIP with Basic Zone User-provided
> > > host name in vCenter Enable L4-L7 network services in the shared
> > > network in the advanced zone
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > docs/en-US/Installation_Guide.xml 2f60aca
> > > docs/en-US/about-working-with-vms.xml 47153e2
> > > docs/en-US/append-displayname-vms.xml PRE-CREATION
> > > docs/en-US/creating-network-offerings.xml ab56920
> > > docs/en-US/elastic-ip.xml PRE-CREATION
> > > docs/en-US/network-offerings.xml c1fd79d
> > > docs/en-US/networks.xml a7b9ea1
> > > docs/en-US/set-up-network-for-users.xml 2b40923
> > > docs/en-US/using-multiple-guest-networks.xml 9076a81
> > > docs/en-US/using-netscaler-load-balancers.xml c2044de
> > > docs/en-US/virtual-machines.xml 7c74932
> > >
> > > Diff: https://reviews.apache.org/r/8180/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > Patch cleanly applies. doc is reviewed by QA
> > >
> > >
> > > Thanks,
> > >
> > > Radhika PC
> > >
> > >
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Animesh Chaturvedi <an...@citrix.com>.
> -----Original Message-----
> From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of Radhika
> PC
> Sent: Thursday, February 14, 2013 7:42 AM
> To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy;
> Jessica Tomechak
> Cc: Radhika Puthiyetath; cloudstack
> Subject: Re: Review Request: Documentation for the new features: Optional
> Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in
> the shared network in the advanced zone, and User-provided hostname in
> vCenter
>
>
>
> > On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP
> clearance 1/30, but comparing the proposed code at
> http://people.apache.org/~muralireddy/ to the current code, I do not see it in
> 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP
> clearance 1/30, but comparing the proposed code at
> http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or
> master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See
> Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving
> to 4.2.0." I have emailed Murali to ask the status of these features.
> >
> > Radhika PC wrote:
> > Once i get the confirmation from Murali, i will resubmit the
> > patch
> >
> > Radhika PC wrote:
> > This patch is applicable only for 4.2 as patch for both bugs 312, 265 did not
> go in to 4.1. Confirmed with Murali.
>
> since creating-network-offering.xml file has been changed now with persistent
> network patch, I shall submit a new patch for this.
>
>
[Animesh>] Radhika so is this patch not relevant anymore? If so please discard it
> - Radhika
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/#review16162
> -----------------------------------------------------------
>
>
> On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8180/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 15, 2013, 12:34 p.m.)
> >
> >
> > Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra
> Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
> >
> >
> > Description
> > -------
> >
> > This review request is for the documentation written for the following
> features:
> >
> > Optional Public IP assignment for EIP with Basic Zone User-provided
> > host name in vCenter Enable L4-L7 network services in the shared
> > network in the advanced zone
> >
> >
> > Diffs
> > -----
> >
> > docs/en-US/Installation_Guide.xml 2f60aca
> > docs/en-US/about-working-with-vms.xml 47153e2
> > docs/en-US/append-displayname-vms.xml PRE-CREATION
> > docs/en-US/creating-network-offerings.xml ab56920
> > docs/en-US/elastic-ip.xml PRE-CREATION
> > docs/en-US/network-offerings.xml c1fd79d
> > docs/en-US/networks.xml a7b9ea1
> > docs/en-US/set-up-network-for-users.xml 2b40923
> > docs/en-US/using-multiple-guest-networks.xml 9076a81
> > docs/en-US/using-netscaler-load-balancers.xml c2044de
> > docs/en-US/virtual-machines.xml 7c74932
> >
> > Diff: https://reviews.apache.org/r/8180/diff/
> >
> >
> > Testing
> > -------
> >
> > Patch cleanly applies. doc is reviewed by QA
> >
> >
> > Thanks,
> >
> > Radhika PC
> >
> >
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
> On Feb. 6, 2013, 3:21 a.m., Jessica Tomechak wrote:
> > CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy/ to the current code, I do not see it in 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving to 4.2.0." I have emailed Murali to ask the status of these features.
>
> Radhika PC wrote:
> Once i get the confirmation from Murali, i will resubmit the patch
>
> Radhika PC wrote:
> This patch is applicable only for 4.2 as patch for both bugs 312, 265 did not go in to 4.1. Confirmed with Murali.
since creating-network-offering.xml file has been changed now with persistent network patch, I shall submit a new patch for this.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review16162
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Jessica Tomechak <je...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review16162
-----------------------------------------------------------
CLOUDSTACK-265, optional public IP for EIP with basic zone: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy/ to the current code, I do not see it in 4.1 or master branches. CLOUDSTACK-312, L4-L7 network services: passed IP clearance 1/30, but comparing the proposed code at http://people.apache.org/~muralireddy to the repo, I do not see it in 4.1 or master branches. CLOUDSTACK-778, user-provided hostname, isn't in 4.1. See Vijay B's comment in the bug today: "The patch didn't make it to 4.1.0. Moving to 4.2.0." I have emailed Murali to ask the status of these features.
- Jessica Tomechak
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Joe Brockmeier <jz...@zonker.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review16155
-----------------------------------------------------------
Are all of the documented features in this patch now included in the 4.1.0 branch?
- Joe Brockmeier
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Animesh Chaturvedi <an...@citrix.com>.
Murali
Is your relevant code in master now
Animesh
> -----Original Message-----
> From: Radhika PC [mailto:noreply@reviews.apache.org] On Behalf Of
> Radhika PC
> Sent: Tuesday, March 05, 2013 1:26 AM
> To: Chip Childers; Joe Brockmeier; Vijayendra Bhamidipati; Murali Reddy;
> Jessica Tomechak
> Cc: Radhika Puthiyetath; cloudstack
> Subject: Re: Review Request: Documentation for the new features: Optional
> Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in
> the shared network in the advanced zone, and User-provided hostname in
> vCenter
>
>
>
> > On March 4, 2013, 9:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > > Ship It!
>
> will merge once Murali merges the code into Master.
>
>
> - Radhika
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/#review17361
> -----------------------------------------------------------
>
>
> On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/8180/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 15, 2013, 12:34 p.m.)
> >
> >
> > Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra
> Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
> >
> >
> > Description
> > -------
> >
> > This review request is for the documentation written for the following
> features:
> >
> > Optional Public IP assignment for EIP with Basic Zone User-provided
> > host name in vCenter Enable L4-L7 network services in the shared
> > network in the advanced zone
> >
> >
> > Diffs
> > -----
> >
> > docs/en-US/Installation_Guide.xml 2f60aca
> > docs/en-US/about-working-with-vms.xml 47153e2
> > docs/en-US/append-displayname-vms.xml PRE-CREATION
> > docs/en-US/creating-network-offerings.xml ab56920
> > docs/en-US/elastic-ip.xml PRE-CREATION
> > docs/en-US/network-offerings.xml c1fd79d
> > docs/en-US/networks.xml a7b9ea1
> > docs/en-US/set-up-network-for-users.xml 2b40923
> > docs/en-US/using-multiple-guest-networks.xml 9076a81
> > docs/en-US/using-netscaler-load-balancers.xml c2044de
> > docs/en-US/virtual-machines.xml 7c74932
> >
> > Diff: https://reviews.apache.org/r/8180/diff/
> >
> >
> > Testing
> > -------
> >
> > Patch cleanly applies. doc is reviewed by QA
> >
> >
> > Thanks,
> >
> > Radhika PC
> >
> >
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
> On March 4, 2013, 9:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Ship It!
will merge once Murali merges the code into Master.
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review17361
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
> On March 4, 2013, 9:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Ship It!
>
> Radhika PC wrote:
> will merge once Murali merges the code into Master.
>
> Animesh Chaturvedi wrote:
> Radhika both 312 and 265 are closed now, can this review be closed now
submitted
commit b7f5197c850f772980b5f4f416878589c3d3e853
Author: unknown <radhikap@BANLRADHIKAP.citrite.net
Date: Wed Apr 24 23:06:25 2013 +0530
CLOUDSTACK-832, CLOUDSTACK-812,CLOUDSTACK-808
- Radhika
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review17361
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
RE: Review Request: Documentation for the new features: Optional
Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services
in the shared network in the advanced zone, and User-provided hostname in
vCenter
Posted by Radhika Puthiyetath <ra...@citrix.com>.
Hi Animesh/ Murali
Thank you for the nudge.
Will submit once I am back to work.
-Radhika
-----Original Message-----
From: Animesh Chaturvedi [mailto:noreply@reviews.apache.org] On Behalf Of Animesh Chaturvedi
Sent: Wednesday, April 17, 2013 7:42 AM
To: Joe Brockmeier; Vijayendra Bhamidipati; Chip Childers; Jessica Tomechak; Murali Reddy
Cc: Radhika Puthiyetath; Animesh Chaturvedi; cloudstack
Subject: Re: Review Request: Documentation for the new features: Optional Public IP assignment for EIP with Basic Zone, Enable L4-L7 network services in the shared network in the advanced zone, and User-provided hostname in vCenter
> On March 4, 2013, 9:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Ship It!
>
> Radhika PC wrote:
> will merge once Murali merges the code into Master.
Radhika both 312 and 265 are closed now, can this review be closed now
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review17361
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone User-provided
> host name in vCenter Enable L4-L7 network services in the shared
> network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On March 4, 2013, 9:21 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > Ship It!
>
> Radhika PC wrote:
> will merge once Murali merges the code into Master.
Radhika both 312 and 265 are closed now, can this review be closed now
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review17361
-----------------------------------------------------------
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review17361
-----------------------------------------------------------
Ship it!
Ship It!
- Venkata Siva Vijayendra Bhamidipati
On Jan. 15, 2013, 12:34 p.m., Radhika PC wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2013, 12:34 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
>
>
> Description
> -------
>
> This review request is for the documentation written for the following features:
>
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter
> Enable L4-L7 network services in the shared network in the advanced zone
>
>
> Diffs
> -----
>
> docs/en-US/Installation_Guide.xml 2f60aca
> docs/en-US/about-working-with-vms.xml 47153e2
> docs/en-US/append-displayname-vms.xml PRE-CREATION
> docs/en-US/creating-network-offerings.xml ab56920
> docs/en-US/elastic-ip.xml PRE-CREATION
> docs/en-US/network-offerings.xml c1fd79d
> docs/en-US/networks.xml a7b9ea1
> docs/en-US/set-up-network-for-users.xml 2b40923
> docs/en-US/using-multiple-guest-networks.xml 9076a81
> docs/en-US/using-netscaler-load-balancers.xml c2044de
> docs/en-US/virtual-machines.xml 7c74932
>
> Diff: https://reviews.apache.org/r/8180/diff/
>
>
> Testing
> -------
>
> Patch cleanly applies. doc is reviewed by QA
>
>
> Thanks,
>
> Radhika PC
>
>
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 12:34 p.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Changes
-------
few more changes has been added after the discussion with Murali.
Description
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Enable L4-L7 network services in the shared network in the advanced zone
Diffs (updated)
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/using-netscaler-load-balancers.xml c2044de
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 11:30 a.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Description (updated)
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Enable L4-L7 network services in the shared network in the advanced zone
Diffs
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/using-netscaler-load-balancers.xml c2044de
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 11:06 a.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Description (updated)
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Enable L4-L7 network services in the shared network in the advanced zone (Limited to SRX Firewall support in the shared network in advanced zone)
Diffs
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/using-netscaler-load-balancers.xml c2044de
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 11:06 a.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Changes
-------
Updated the diff with the addition of updates on SRX support in shared network in advanced zone.
Description
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Enable L4-L7 network services in the shared network in the advanced zone
Diffs (updated)
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/using-netscaler-load-balancers.xml c2044de
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC
Re: Review Request: Documentation for the new features: Optional Public IP
assignment for EIP with Basic Zone,
Enable L4-L7 network services in the shared network in the advanced zone,
and User-provided hostname in vCenter
Posted by Radhika PC <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/
-----------------------------------------------------------
(Updated Jan. 15, 2013, 7:01 a.m.)
Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica Tomechak, Murali Reddy, and Joe Brockmeier.
Description (updated)
-------
This review request is for the documentation written for the following features:
Optional Public IP assignment for EIP with Basic Zone
User-provided host name in vCenter
Enable L4-L7 network services in the shared network in the advanced zone
Diffs
-----
docs/en-US/Installation_Guide.xml 2f60aca
docs/en-US/about-working-with-vms.xml 47153e2
docs/en-US/append-displayname-vms.xml PRE-CREATION
docs/en-US/creating-network-offerings.xml ab56920
docs/en-US/elastic-ip.xml PRE-CREATION
docs/en-US/network-offerings.xml c1fd79d
docs/en-US/networks.xml a7b9ea1
docs/en-US/set-up-network-for-users.xml 2b40923
docs/en-US/using-multiple-guest-networks.xml 9076a81
docs/en-US/virtual-machines.xml 7c74932
Diff: https://reviews.apache.org/r/8180/diff/
Testing
-------
Patch cleanly applies. doc is reviewed by QA
Thanks,
Radhika PC