You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2016/10/21 21:11:17 UTC
[GitHub] tinkerpop pull request #460: TINKERPOP-1507: Pick.any and Pick.none are not ...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/460
TINKERPOP-1507: Pick.any and Pick.none are not in GraphSON or Gremlin-Python
https://issues.apache.org/jira/browse/TINKERPOP-1507
`Pick.any` and `Pick.none` were not in any of the registered serialization systems -- Java or Python. Nor in the static imports. This has since been rectified and two new test cases add to `BranchTest` and `ChooseTest` to demonstrate that these tokens are now being processed correctly.
CHANGELOG
```
* Added `Pick.none` and `Pick.any` to the serializers and importers.
```
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1507
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #460
----
commit 0fec46db21a3af0604a85b9b4bed4e47db8d1a70
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2016-10-21T19:07:18Z
added Pick.none and Pick.any to the CoreImports. Added it to both GraphSONModule and GryoMapper. Added two new test cases which use any and none -- one in ChooseTest and one in BranchTest. Added none/any to GroovyTranslator and PythonTranslator. All good in the hood.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/460
Its branched off the `tp32` line. I just fuggled the "wants to merge to." I will merge it to `tp32` come the time and upmerge to `master`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/460
Shouldn't this be a fix to tp32 and 3.2.x line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/460
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/460
Updated `graphson.asciidoc`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/460
Note that the graphson.asciidoc generation isn't automatic. it's a script you have to run manually (so the content it generates isn't currently present if you were to generate docs). It can be run later i guess. Like i said, it's not a terribly automated process atm.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #460: TINKERPOP-1507: Pick.any and Pick.none are not ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #460: TINKERPOP-1507: Pick.any and Pick.none are not in Grap...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/460
> I will merge it to tp32 come the time and upmerge to master.
enjoy that while it lasts :)
Since you added new types for GraphSON, you should update the IO Reference Documentation:
https://github.com/apache/tinkerpop/blob/42090f2e8445242bd662fed5fd9a0b255a5e46f9/docs/src/dev/io/graphson.asciidoc
I can't link directly to the part of the file to update, but basically, the comments of that file contain a groovy script which generates a portion of the graphson.asciidoc file (just cut/paste output into it). As I explain this, I realize that perhaps this process could be nicer, but it is what it is for now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---