You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/10/20 05:06:27 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-351 - Can't remove elems...
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/353
ZEPPELIN-351 - Can't remove elems in pivot
Fix ZEPPELIN-351, On Firefox, we couldn't remove pivot elements from groups and keys.
Click event wasn't going through the `button` container, so I changed container to `div`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/ZEPPELIN-351
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit 86f16fb9b02af73c8958eccb1871fc8b2e0eb2e8
Author: Damien CORNEAU <co...@gmail.com>
Date: 2015-10-20T03:02:13Z
Replace button by div in pivot settings
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-351 - Can't remove elems...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/353
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-351 - Can't remove elems...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/353#issuecomment-149764891
Tested with Firefox. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-351 - Can't remove elems...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/353#issuecomment-149414631
Ready To Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---