You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/07/09 23:07:45 UTC

[GitHub] [hbase-native-client] bharathv commented on a change in pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

bharathv commented on a change in pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#discussion_r452536952



##########
File path: CMakeLists.txt
##########
@@ -117,23 +124,22 @@ endif()
 
 include_directories("${JAVA_HBASE_DIR}/hbase-common/target/generated-sources/native/")
 ############
-## Validate that we have C++ 14 support
+## Validate that we have C++ 17 support

Review comment:
       Ya, preferred to keep at 14 unless there is a lot of upside IMO. Like I mentioned in my other patch, we are going to have a precommit soon, so we will have good test coverage in a clean environment once we get #10 in.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org