[GitHub] [trafficcontrol] rawlinp opened a new pull request #4359: [Backport 4.0.x] Fix TO atscfg missing max origin conns (#4344)

[GitBox <gi...@apache.org>]

rawlinp opened a new pull request #4359: [Backport 4.0.x] Fix TO atscfg missing max origin conns (#4344)
URL: https://github.com/apache/trafficcontrol/pull/4359
 
 
   Fixes a misordered SQL scan, which caused the Server Status to be
   missing, causing the config gen to think there were no online servers,
   and thus not create the max_origin_connections entry.
   
   Note this is only in the old TO endpoints, not the config generator. The `atstccfg` generator doesn't have this issue.
   
   - [x] This PR is not related to any other Issue
   
   Includes TO API (Integration) tests.
   No docs, no interface change.
   No changelog, no interface change.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Run TO API Tests.
   Set Max Origin Connections on a DS, request the header rewrite endpoint for that DS, verify it includes a max_origin_connections entry.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master 
   - 4.0.0 RC2
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] rawlinp merged pull request #4359: [Backport 4.0.x] Fix TO atscfg missing max origin conns (#4344)

[GitBox <gi...@apache.org>]

rawlinp merged pull request #4359: [Backport 4.0.x] Fix TO atscfg missing max origin conns (#4344)
URL: https://github.com/apache/trafficcontrol/pull/4359
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services