You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Gregory Shimansky (JIRA)" <ji...@apache.org> on 2006/09/11 16:00:22 UTC
[jira] Created: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
[drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
-----------------------------------------------------------------------------------------
Key: HARMONY-1427
URL: http://issues.apache.org/jira/browse/HARMONY-1427
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Gregory Shimansky
Attachments: JNI-ExceptionDescribe.patch
Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1427?page=all ]
Gregory Shimansky updated HARMONY-1427:
---------------------------------------
Attachment: JNI-ExceptionDescribe.patch
Patch to fix this problem.
> [drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-1427
> URL: http://issues.apache.org/jira/browse/HARMONY-1427
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Attachments: JNI-ExceptionDescribe.patch
>
>
> Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1427?page=comments#action_12435335 ]
weldon washburn commented on HARMONY-1427:
------------------------------------------
Rewriting in JNI probably explains the change in suspend mode state. GC suspend needs to be enabled before entering a JNI function. It turns out that the JNI mechanism will toggle suspend enable/disable at the appropriate times internally.
> [drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-1427
> URL: http://issues.apache.org/jira/browse/HARMONY-1427
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Attachments: JNI-ExceptionDescribe.patch
>
>
> Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
Posted by "weldon washburn (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1427?page=comments#action_12435095 ]
weldon washburn commented on HARMONY-1427:
------------------------------------------
this patch is simple enough. I am OK with committing it. It would be good to add a description why the suspend mode had to be changed. Is it because the execution path includes java methods and those methods occasionally attempt to allocate an object while a GC is underway thus causing a deadlock?
> [drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-1427
> URL: http://issues.apache.org/jira/browse/HARMONY-1427
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Attachments: JNI-ExceptionDescribe.patch
>
>
> Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1427?page=comments#action_12435122 ]
Gregory Shimansky commented on HARMONY-1427:
--------------------------------------------
I am actually not sure why suspend mode was changed. It is a result of applied HARMONY-1363. It looks like the exn_print_stack_trace function was rewritten to JNI calls using exn_jni_print_stack_trace which should work in suspend enabled mode and ExceptionDescribe in JNI was just forgotten to be changed.
> [drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-1427
> URL: http://issues.apache.org/jira/browse/HARMONY-1427
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Attachments: JNI-ExceptionDescribe.patch
>
>
> Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1427) [drlvm] ExceptionDescribe
incorrectly disables suspend when calling exn_print_stack_trace
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1427?page=all ]
Geir Magnusson Jr resolved HARMONY-1427.
----------------------------------------
Resolution: Fixed
r446796
tested on ubuntu, smoke and c-unit ok
> [drlvm] ExceptionDescribe incorrectly disables suspend when calling exn_print_stack_trace
> -----------------------------------------------------------------------------------------
>
> Key: HARMONY-1427
> URL: http://issues.apache.org/jira/browse/HARMONY-1427
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Gregory Shimansky
> Attachments: JNI-ExceptionDescribe.patch
>
>
> Looks like the mode in which exn_print_stack_trace works has changed. It is now suspend_enabled, and inside of this function there is an assertion that suspend is enabled. But the change was not applied to JNI ExceptionDescribe function. It still disables suspend when calling exn_print_stack_trace.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira