You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Stefan Betermieux (JIRA)" <de...@myfaces.apache.org> on 2007/01/11 11:39:27 UTC

[jira] Created: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

displayValueOnly on input elements who are required triggers validation
-----------------------------------------------------------------------

                 Key: TOMAHAWK-850
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Validators
    Affects Versions: 1.1.5-SNAPSHOT
            Reporter: Stefan Betermieux


Hi,
using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:

        <f:view>
            <h:form id="form">
                <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
                <h:commandButton id="button" value="press me" action="success"/>
                <h:message id="message" for="input"/>
            </h:form>
        </f:view>

The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Stefan Betermieux (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467140 ] 

Stefan Betermieux commented on TOMAHAWK-850:
--------------------------------------------

Some more information:

- this is a regression, it worked some months ago

- the problem can be traced to the validate() method of UIInput, which checks the submittedValue (which is null in case of displayValueOnly) and triggers the validation error. Shouldn't displayValueOnly prevent these checks? I am not sure how it is supposed to work, maybe someone can give some hints. I have looked in the displayValueOnly-Version of HtmlInputText (from org.apache.myfaces.component.html.ext), but i can't find any hints.

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Stefan Betermieux (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Betermieux reopened TOMAHAWK-850:
----------------------------------------


maybe we should leave it open, until MYFACES-1467 is resolved.

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467844 ] 

Jeff Bischoff commented on TOMAHAWK-850:
----------------------------------------

Cagatay,

Wait, does that mean we reverted and lost the security patch from MYFACES-1467?

I know we are hoping for some spec clarification on that one, but did we decide in the meantime to stick with the security patch or the original behaviour?

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>             Fix For: 1.1.5-SNAPSHOT
>
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Cagatay Civici (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cagatay Civici resolved TOMAHAWK-850.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.5-SNAPSHOT

Resolved since changes related to MYFACES-1467 are reverted.

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>             Fix For: 1.1.5-SNAPSHOT
>
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Cagatay Civici (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467862 ] 

Cagatay Civici commented on TOMAHAWK-850:
-----------------------------------------

Yes we definitely need a spec clarification. For now the security patch is reverted and original behaviour is restored because the patch has many side effects like this issue.

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>             Fix For: 1.1.5-SNAPSHOT
>
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Stefan Betermieux (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12467278 ] 

Stefan Betermieux commented on TOMAHAWK-850:
--------------------------------------------

I have found the culprit, it is a change in the third line of UIInput.validate():

if (submittedValue == null) return;

changed by tomsp on November 22 (commit 478342) to fix MYFACES-1567 

if (submittedValue == null && !this.isRequired()) return;

since the issue is still in discussion, I would suggest to mark this as a duplicate and continue the discussion there.

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-850) displayValueOnly on input elements who are required triggers validation

Posted by "Stefan Betermieux (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Betermieux resolved TOMAHAWK-850.
----------------------------------------

    Resolution: Duplicate

see MYFACES-1467

> displayValueOnly on input elements who are required triggers validation
> -----------------------------------------------------------------------
>
>                 Key: TOMAHAWK-850
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-850
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Validators
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Stefan Betermieux
>         Assigned To: Cagatay Civici
>
> Hi,
> using the latest SVN snapshot, I get a validation error message when I use an UIInput (for example InputText) with displayValueOnly="true" and required="true". It is simple to reproduce:
>         <f:view>
>             <h:form id="form">
>                 <t:inputText id="input" value="Test" required="true" displayValueOnly="true"/>
>                 <h:commandButton id="button" value="press me" action="success"/>
>                 <h:message id="message" for="input"/>
>             </h:form>
>         </f:view>
> The replacement of my value bean lookups by static strings hasn't affected the outcome, a validation error ("input": Value is required.) is always triggered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.