[jira] [Commented] (ARROW-14310) [R] Make expect_dplyr_equal() more intuitive and understandable

["Nicola Crane (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-14310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428259#comment-17428259 ] 

Nicola Crane commented on ARROW-14310:
--------------------------------------

Possible names:

{{compare_binding}} as we are comparing either a dplyr verb, a verb to use inside the binding, or both, between the version that uses the dplyr engine vs. arrow engine.

{{compare_dplyr_binding}} - more words but more precision

Could we perhaps also rename {{input}} to {{.input}} to provide extra cues to the fact that it's a "special" variable? 





> [R] Make expect_dplyr_equal() more intuitive and understandable
> ---------------------------------------------------------------
>
>                 Key: ARROW-14310
>                 URL: https://issues.apache.org/jira/browse/ARROW-14310
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Nicola Crane
>            Assignee: Nicola Crane
>            Priority: Major
>
> Possible things to do:
> * rename this function so it doesn't break people's model of how {{expect_*}} functions work
> * add inline comments to chunks to simplify
> * add a description in the oxygen header to describe in a few sentences what it's doing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)