You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Supreeth Sharma <su...@gmail.com> on 2017/04/21 08:35:39 UTC
Review Request 58567: Need way to explicitly ask for workflow name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
Bugs: AMBARI-20729
https://issues.apache.org/jira/browse/AMBARI-20729
Repository: ambari
Description
-------
Made the code change to explicitly ask for names while creating coordinator and bundle
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 99f4fa7
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fba4db5
Diff: https://reviews.apache.org/r/58567/diff/1/
Testing
-------
Manual testing done
Thanks,
Supreeth Sharma
Re: Review Request 58567: Need way to explicitly ask for workflow name
Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172618
-----------------------------------------------------------
Ship it!
Ship It!
- Padma Priya N
On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:35 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Made the code change to explicitly ask for names while creating coordinator and bundle
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 99f4fa7
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fba4db5
>
>
> Diff: https://reviews.apache.org/r/58567/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>
Re: Review Request 58567: Need way to explicitly ask for workflow name
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172625
-----------------------------------------------------------
Ship it!
Ship It!
- venkat sairam
On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:35 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Made the code change to explicitly ask for names while creating coordinator and bundle
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 99f4fa7
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fba4db5
>
>
> Diff: https://reviews.apache.org/r/58567/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>
Re: Review Request 58567: Need way to explicitly ask for workflow name
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58567/#review172626
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On April 21, 2017, 8:35 a.m., Supreeth Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58567/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 8:35 a.m.)
>
>
> Review request for Ambari, belliraj hb, Padma Priya N, Rohit Choudhary, and venkat sairam.
>
>
> Bugs: AMBARI-20729
> https://issues.apache.org/jira/browse/AMBARI-20729
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Made the code change to explicitly ask for names while creating coordinator and bundle
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 99f4fa7
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js fba4db5
>
>
> Diff: https://reviews.apache.org/r/58567/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> Supreeth Sharma
>
>