You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/30 19:11:06 UTC

[GitHub] [airflow] kimyen opened a new issue #17919: Helm substitution changes the values for statsd mapping

kimyen opened a new issue #17919:
URL: https://github.com/apache/airflow/issues/17919


   ### Official Helm Chart version
   
   1.1.0 (latest released)
   
   ### Apache Airflow version
   
   2.0.2
   
   ### Kubernetes Version
   
   1.19.11
   
   ### Helm Chart configuration
   
   ```
   statsd:
     enabled: true
     nodeSelector:
       github.com/poolname: airflow
     extraMappings:
       - match: "airflow.*_start"
          name: "airflow.job.start"
          tags:
             job_name: "$1"
   ```
   
   ### Docker Image customisations
   
   None
   
   ### What happened
   
   In `airflow-statsd` configmap in K8s, I see:
   ```
     - match: airflow.*_start
       name: airflow.job.start
       tags:
         job_name:
   ```
   
   Double quotes are removed, which is fine. But the `$1` is evaluated to nothing. 
   
   ### What you expected to happen
   
   In `airflow-statsd` configmap in K8s, I would see:
   ```
       - match: "airflow.*_start"
          name: "airflow.job.start"
          tags:
             job_name: "$1"
   ```
   
   ### How to reproduce
   
   See above values
   
   ### Anything else
   
   There is a lack of documentation on how to specify data for `extraMappings`. I would imagine if there is an escape character to be used here, it would go in to the doc where we give example on what an extra mapping looks like.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17919: Helm substitution changes the values for statsd mapping

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17919:
URL: https://github.com/apache/airflow/issues/17919#issuecomment-908613105


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17919: Helm substitution changes the values for statsd mapping

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17919:
URL: https://github.com/apache/airflow/issues/17919#issuecomment-908613105


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org