You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/17 09:35:16 UTC
[GitHub] [flink] KurtYoung commented on a change in pull request #8758:
[FLINK-12867] Add insert overwrite grammar as HIVE dialect
KurtYoung commented on a change in pull request #8758: [FLINK-12867] Add insert overwrite grammar as HIVE dialect
URL: https://github.com/apache/flink/pull/8758#discussion_r294212182
##########
File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dml/RichSqlInsert.java
##########
@@ -77,7 +81,7 @@ public SqlNodeList getStaticPartitions() {
@Override public void unparse(SqlWriter writer, int leftPrec, int rightPrec) {
writer.startList(SqlWriter.FrameTypeEnum.SELECT);
- writer.sep(isUpsert() ? "UPSERT INTO" : "INSERT INTO");
+ writer.sep(isUpsert2() ? "UPSERT INTO" : isOverwrite() ? "INSERT OVERWRITE" : "INSERT INTO");
Review comment:
don't write nested `?:`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services