You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/05 00:13:13 UTC
[GitHub] [superset] eschutho commented on a change in pull request #13448: feat: add option to load big/wide tables
eschutho commented on a change in pull request #13448:
URL: https://github.com/apache/superset/pull/13448#discussion_r587929455
##########
File path: superset/cli.py
##########
@@ -109,7 +109,10 @@ def version(verbose: bool) -> None:
def load_examples_run(
- load_test_data: bool, only_metadata: bool = False, force: bool = False
+ load_test_data: bool,
+ load_big_data: bool,
+ only_metadata: bool = False,
+ force: bool = False,
Review comment:
this is a bit of a nit, but for consistency, do you think it's better to have default `False` values on all of these or allow nulls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org