You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/13 00:17:13 UTC
[GitHub] [superset] jsoref opened a new pull request, #19677: Spelling backend
jsoref opened a new pull request, #19677:
URL: https://github.com/apache/superset/pull/19677
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Subset of #19648 per https://github.com/apache/superset/pull/19648#pullrequestreview-939431828
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1414278404
@jsoref we got the frontend one merged, thanks for all your hard work! I think this one is ready to go if it can be rebased to mitigate the last conflicts. There also might be some issue with the python linting, but I'm having a hard time fixing it since my local python env is _not happy_ with the pre-commit hook at the moment. Maybe the rebase will magically fix things 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19677: chore(backend): Spelling
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1097423997
# [Codecov](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19677](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3885998) into [master](https://codecov.io/gh/apache/superset/commit/b45f89b9540442fe398831e1f29dfd60a153bab6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b45f89b) will **decrease** coverage by `9.84%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #19677 +/- ##
==========================================
- Coverage 66.49% 56.64% -9.85%
==========================================
Files 1681 451 -1230
Lines 64370 31699 -32671
Branches 6583 0 -6583
==========================================
- Hits 42803 17957 -24846
+ Misses 19886 13742 -6144
+ Partials 1681 0 -1681
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `52.69% <33.33%> (+0.02%)` | :arrow_up: |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.54% <33.33%> (+0.02%)` | :arrow_up: |
| python | `56.64% <33.33%> (-25.74%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `47.75% <25.00%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `99.35% <ø> (ø)` | |
| [superset/cli/importexport.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL2ltcG9ydGV4cG9ydC5weQ==) | `20.00% <ø> (-60.00%)` | :arrow_down: |
| [superset/cli/update.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL3VwZGF0ZS5weQ==) | `0.00% <ø> (ø)` | |
| [superset/common/not\_authorized\_object.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL25vdF9hdXRob3JpemVkX29iamVjdC5weQ==) | `66.66% <ø> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.52% <ø> (-4.74%)` | :arrow_down: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.08% <ø> (-0.34%)` | :arrow_down: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `26.41% <ø> (-56.58%)` | :arrow_down: |
| [superset/dao/base.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFvL2Jhc2UucHk=) | `68.96% <ø> (-24.14%)` | :arrow_down: |
| [superset/dashboards/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | `69.86% <ø> (-15.07%)` | :arrow_down: |
| [superset/dashboards/filter\_state/api.py](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJfc3RhdGUvYXBpLnB5) | `82.97% <ø> (-17.03%)` | :arrow_down: |
| ... and [1539 more](https://codecov.io/gh/apache/superset/pull/19677/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b45f89b...3885998](https://codecov.io/gh/apache/superset/pull/19677?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r848986389
##########
docs/static/resources/openapi.json:
##########
@@ -4905,7 +4905,7 @@
],
"type": "object"
},
- "DistincResponseSchema": {
+ "DistinctResponseSchema": {
Review Comment:
This is assumed to be problematic, so I'm going to drop it momentarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087312562
##########
superset/connectors/sqla/models.py:
##########
@@ -755,7 +755,7 @@ def sql_url(self) -> str:
return self.database.sql_url + "?table_name=" + str(self.table_name)
def external_metadata(self) -> List[Dict[str, str]]:
- # todo(yongjie): create a pysical table column type in seprated PR
+ # todo(yongjie): create a physical table column type in a separate PR
Review Comment:
I've added an `a` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on pull request #19677: chore(backend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1404246250
@rusackas: done. Note that I'm not rechecking, it's just a naive rebase. If you merge the current PR(s), I can rerun to catch things that were introduced in the interim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1090333534
##########
docs/static/resources/openapi.json:
##########
@@ -561,7 +561,7 @@
"CacheInvalidationRequestSchema": {
"properties": {
"datasource_uids": {
- "description": "The uid of the dataset/datasource this new chart will use. A complete datasource identification needs `datasouce_uid` ",
+ "description": "The uid of the dataset/datasource this new chart will use. A complete datasource identification needs `datasource_uid` ",
Review Comment:
this needs to be changed here: https://github.com/apache/superset/blob/master/superset/charts/schemas.py#L109 and then regenerate the OAS, the spec should not be edited directly
##########
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:
##########
@@ -930,7 +930,7 @@ columns:
expression: null
description: null
python_date_format: null
-- column_name: rsrc_pluralsght
Review Comment:
Just checked it's the column name on the examples, will prob cause some impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1095225183
##########
superset/examples/configs/charts/Messages_per_Channel.yaml:
##########
@@ -50,7 +50,7 @@ params:
dashboards: '#3CCCCB'
design: '#1FA8C9'
developers: '#9EE5E5'
- embedd-dashboards: '#ACE1C4'
+ embedded-dashboards: '#ACE1C4'
Review Comment:
This is actually a value in the data. If we change this, it will break the example chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1095225381
##########
superset/examples/configs/dashboards/Slack_Dashboard.yaml:
##########
@@ -251,7 +251,7 @@ metadata:
superset_stage_alerts: "#A38F79"
contributing: "#8FD3E4"
graduation: "#A1A6BD"
- embedd-dashboards: "#ACE1C4"
+ embedded-dashboards: "#ACE1C4"
Review Comment:
```suggestion
embedd-dashboards: "#ACE1C4"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087274458
##########
helm/superset/Chart.yaml:
##########
@@ -29,7 +29,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
-version: 0.8.4
+version: 0.8.5
Review Comment:
Not sure if this change is intentional...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1428835264
Re-requesting @eschutho's review... I believe the requested changes have been addressed (or reversed, in some cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1406913477
This PR needs a little rebase, but also needs code owner approval from @craig-rueda @dpgaspar or @villebro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1090274119
##########
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:
##########
@@ -1320,7 +1320,7 @@ columns:
expression: null
description: null
python_date_format: null
-- column_name: curr_emplymnt_other
+- column_name: curr_employment_other
Review Comment:
I think we need to double check that this doesn't break examples creation, as I assume this is the actual name of the column in the dataset..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r848986532
##########
docs/docs/miscellaneous/chart-params.mdx:
##########
@@ -18,7 +18,7 @@ Note not all fields are correctly categorized. The fields vary based on visualiz
| Field | Type | Notes |
| ----------------- | -------- | ----------------------------------- |
| `database_name` | _string_ | _Deprecated?_ |
-| `datasource` | _string_ | `<datasouce_id>__<datasource_type>` |
+| `datasource` | _string_ | `<datasource_id>__<datasource_type>` |
Review Comment:
I'm happy to update the table, but I'd rather wait until I get a general acceptance of the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by GitBox <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r848987934
##########
superset/reports/schemas.py:
##########
@@ -84,7 +84,7 @@
"Superset nags you again. (in seconds)"
)
working_timeout_description = (
- "If an alert is staled at a working state, how long until it's state is reseted to"
+ "If an alert is staled at a working state, how long until its state is reset to"
Review Comment:
As noted in https://github.com/apache/superset/pull/19648#discussion_r847405605, I'm not generally doing grammar fixes, this was just in the neighborhood for the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1433563045
Thanks @eschutho! I think we still need @dpgaspar / @villebro / @craig-rueda to approve this as code owners.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1090908290
##########
docs/static/resources/openapi.json:
##########
@@ -561,7 +561,7 @@
"CacheInvalidationRequestSchema": {
"properties": {
"datasource_uids": {
- "description": "The uid of the dataset/datasource this new chart will use. A complete datasource identification needs `datasouce_uid` ",
+ "description": "The uid of the dataset/datasource this new chart will use. A complete datasource identification needs `datasource_uid` ",
Review Comment:
For reference, that *was* changed in this PR by the same commit.
However, in the interest of not dealing w/ this mess at this time, I'm dropping all commits that touch this file. We can deal w/ it in a distinct PR, or perhaps someone else can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on pull request #19677: chore(backend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1414305293
@rusackas: thanks. I ran into someone's git hooks earlier today -- I *hate* hooks. So you definitely have my sympathy and appreciation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1095227384
##########
superset/examples/multiformat_time_series.py:
##########
@@ -98,7 +98,7 @@ def load_multiformat_time_series( # pylint: disable=too-many-locals
for col in obj.columns:
dttm_and_expr = dttm_and_expr_dict[col.column_name]
col.python_date_format = dttm_and_expr[0]
- col.dbatabase_expr = dttm_and_expr[1]
+ col.database_expr = dttm_and_expr[1]
Review Comment:
I think this value has been deprecated, but if you want to be safe, you can change it to `col.database_expression`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1404228365
Sorry this has fallen through the cracks for so long @jsoref - would you mind rebasing this? These are some pretty embarrassing typos, so I hope we can (finally) get this reviewed and merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1409519794
@dpgaspar the files that caused some concern in this PR have been reverted to their original state. I think everything is working as expected now and CI is passing, if you (or any other code owner reading this) can give it a final check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #19677:
URL: https://github.com/apache/superset/pull/19677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087289871
##########
docs/docs/miscellaneous/chart-params.mdx:
##########
@@ -18,7 +18,7 @@ Note not all fields are correctly categorized. The fields vary based on visualiz
| Field | Type | Notes |
| ----------------- | -------- | ----------------------------------- |
| `database_name` | _string_ | _Deprecated?_ |
-| `datasource` | _string_ | `<datasouce_id>__<datasource_type>` |
+| `datasource` | _string_ | `<datasource_id>__<datasource_type>` |
Review Comment:
I guess we're there now :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #19677:
URL: https://github.com/apache/superset/pull/19677#issuecomment-1404364942
Looks like this just needs a little more love...
* Just one conflict
* A table update?
* looks like `helpers.py` didn't have an instance of `allows_hidden_ordeby_agg` get updated to `allows_hidden_orderby_agg` which is causing some errors on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jsoref commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087312224
##########
docs/docs/miscellaneous/chart-params.mdx:
##########
@@ -72,7 +72,7 @@ Note not all fields are correctly categorized. The fields vary based on visualiz
| `columns` | _array(string)_ | The **Breakdowns** widget |
| `groupby` | _array(string)_ | The **Group by** or **Series** widget |
| `limit` | _number_ | The **Series Limit** widget |
-| `metric`<br/>`metric_2`<br/>`metrics`<br/>`percent_mertics`<br/>`secondary_metric`<br/>`size`<br/>`x`<br/>`y` | _string_,_object_,_array(string)_,_array(object)_ | The metric(s) depending on the visualization type |
+| `metric`<br/>`metric_2`<br/>`metrics`<br/>`percent_metrics`<br/>`secondary_metric`<br/>`size`<br/>`x`<br/>`y` | _string_,_object_,_array(string)_,_array(object)_ | The metric(s) depending on the visualization type |
Review Comment:
This table was already broken wrt alignment, so I'm not going to fix it -- if someone wants to lint all the markdown in this repository, I'll leave that to them for a distinct change (this is already quite large)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087278231
##########
superset/connectors/sqla/models.py:
##########
@@ -755,7 +755,7 @@ def sql_url(self) -> str:
return self.database.sql_url + "?table_name=" + str(self.table_name)
def external_metadata(self) -> List[Dict[str, str]]:
- # todo(yongjie): create a pysical table column type in seprated PR
+ # todo(yongjie): create a physical table column type in separated PR
Review Comment:
```suggestion
# todo(yongjie): create a physical table column type in separate PR
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1087280661
##########
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:
##########
@@ -930,7 +930,7 @@ columns:
expression: null
description: null
python_date_format: null
-- column_name: rsrc_pluralsght
Review Comment:
@betodealmeida would the changes in this file pose any potential danger to anyone's workflows? Legit spelling fixes, but want to make sure this yaml change doesn't cause fallout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1090330180
##########
superset/examples/configs/datasets/examples/FCC_2018_Survey.yaml:
##########
@@ -1320,7 +1320,7 @@ columns:
expression: null
description: null
python_date_format: null
-- column_name: curr_emplymnt_other
+- column_name: curr_employment_other
Review Comment:
good catch, yes it is the column name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #19677: chore(backend): Spelling
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #19677:
URL: https://github.com/apache/superset/pull/19677#discussion_r1095223235
##########
superset/databases/decorators.py:
##########
@@ -55,7 +55,7 @@ def wraps(
database, Table(table_name_parsed, schema_name_parsed)
):
stats_logger_manager.instance.incr(
- f"permisssion_denied_{self.__class__.__name__}.select_star"
+ f"permission_denied_{self.__class__.__name__}.select_star"
Review Comment:
changing this value can affect people's metrics if they actively watching this value. That said, we don't have strict semver guidelines around logging and breaking changes, and I don't think that this value is used much. I'm probably ok with letting this slip through, but curious if anyone else has concerns. We can also wait until 3.0, but you'll likely have merge conflicts with these files if you wait that long to merge. Or you can just remove this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org