You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/29 23:46:14 UTC
[GitHub] [superset] betodealmeida opened a new pull request #12840: WIP
betodealmeida opened a new pull request #12840:
URL: https://github.com/apache/superset/pull/12840
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (4317a8f) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `3.32%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
==========================================
- Coverage 67.00% 63.68% -3.33%
==========================================
Files 1022 489 -533
Lines 50105 30192 -19913
Branches 5191 0 -5191
==========================================
- Hits 33572 19227 -14345
+ Misses 16402 10965 -5437
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.68% <93.33%> (-0.39%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.93% <91.66%> (-0.09%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `89.78% <0.00%> (-2.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [550 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...4317a8f](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (150b55e) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `16.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
===========================================
- Coverage 67.00% 50.91% -16.10%
===========================================
Files 1022 438 -584
Lines 50105 14729 -35376
Branches 5191 3922 -1269
===========================================
- Hits 33572 7499 -26073
+ Misses 16402 7230 -9172
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.91% <ø> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...erset-frontend/src/common/hooks/useChangeEffect.ts](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9ob29rcy91c2VDaGFuZ2VFZmZlY3QudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=) | `3.40% <0.00%> (-87.02%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [897 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...150b55e](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (4317a8f) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `3.32%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
==========================================
- Coverage 67.00% 63.67% -3.33%
==========================================
Files 1022 489 -533
Lines 50105 30207 -19898
Branches 5191 0 -5191
==========================================
- Hits 33572 19234 -14338
+ Misses 16402 10973 -5429
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.67% <93.33%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.93% <91.66%> (-0.09%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `73.84% <0.00%> (-17.31%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.38% <0.00%> (-6.71%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `89.78% <0.00%> (-2.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `89.79% <0.00%> (-2.05%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.70% <0.00%> (-1.76%)` | :arrow_down: |
| ... and [543 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...4317a8f](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-772025142
@etr2460 the other places where user can type SQL don't have autocomplete for function names. I created a ticket for this: https://github.com/apache/superset/issues/12899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-772025142
@etr2460 the other places where user can type SQL don't have autocomplete for function names. I created a ticket for this: https://github.com/apache/superset/issues/12899
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12840:
URL: https://github.com/apache/superset/pull/12840#discussion_r568837306
##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -1300,3 +1302,23 @@ export function createCtasDatasource(vizOptions) {
});
};
}
+
+export function queryEditorSetFunctionNames(queryEditor, dbId) {
+ return function (dispatch) {
+ return SupersetClient.get({
+ endpoint: encodeURI(`/api/v1/database/${dbId}/function_names/`),
+ })
+ .then(({ json }) =>
+ dispatch({
+ type: QUERY_EDITOR_SET_FUNCTION_NAMES,
+ queryEditor,
+ functionNames: json.function_names,
+ }),
+ )
+ .catch(() =>
+ dispatch(
+ addDangerToast(t('An error occurred while fetching function names')),
Review comment:
nit: there should be a period in this sentence
##########
File path: superset/databases/schemas.py
##########
@@ -413,11 +413,15 @@ class DatabaseRelatedObjectsResponse(Schema):
dashboards = fields.Nested(DatabaseRelatedDashboards)
+class DatabaseFunctionNamesResponse(Schema):
+ function_names = fields.List(fields.String())
+
+
class ImportV1DatabaseExtraSchema(Schema):
metadata_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
engine_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
metadata_cache_timeout = fields.Dict(keys=fields.Str(), values=fields.Integer())
- schemas_allowed_for_csv_upload = fields.List(fields.String)
+ schemas_allowed_for_csv_upload = fields.List(fields.String())
Review comment:
should this change be here? Also how is `fields.Str()` different from `fields.String()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #12840:
URL: https://github.com/apache/superset/pull/12840#discussion_r568837306
##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -1300,3 +1302,23 @@ export function createCtasDatasource(vizOptions) {
});
};
}
+
+export function queryEditorSetFunctionNames(queryEditor, dbId) {
+ return function (dispatch) {
+ return SupersetClient.get({
+ endpoint: encodeURI(`/api/v1/database/${dbId}/function_names/`),
+ })
+ .then(({ json }) =>
+ dispatch({
+ type: QUERY_EDITOR_SET_FUNCTION_NAMES,
+ queryEditor,
+ functionNames: json.function_names,
+ }),
+ )
+ .catch(() =>
+ dispatch(
+ addDangerToast(t('An error occurred while fetching function names')),
Review comment:
nit: there should be a period in this sentence
##########
File path: superset/databases/schemas.py
##########
@@ -413,11 +413,15 @@ class DatabaseRelatedObjectsResponse(Schema):
dashboards = fields.Nested(DatabaseRelatedDashboards)
+class DatabaseFunctionNamesResponse(Schema):
+ function_names = fields.List(fields.String())
+
+
class ImportV1DatabaseExtraSchema(Schema):
metadata_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
engine_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
metadata_cache_timeout = fields.Dict(keys=fields.Str(), values=fields.Integer())
- schemas_allowed_for_csv_upload = fields.List(fields.String)
+ schemas_allowed_for_csv_upload = fields.List(fields.String())
Review comment:
should this change be here? Also how is `fields.Str()` different from `fields.String()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida merged pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #12840:
URL: https://github.com/apache/superset/pull/12840
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12840:
URL: https://github.com/apache/superset/pull/12840#discussion_r568936661
##########
File path: superset/databases/schemas.py
##########
@@ -413,11 +413,15 @@ class DatabaseRelatedObjectsResponse(Schema):
dashboards = fields.Nested(DatabaseRelatedDashboards)
+class DatabaseFunctionNamesResponse(Schema):
+ function_names = fields.List(fields.String())
+
+
class ImportV1DatabaseExtraSchema(Schema):
metadata_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
engine_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
metadata_cache_timeout = fields.Dict(keys=fields.Str(), values=fields.Integer())
- schemas_allowed_for_csv_upload = fields.List(fields.String)
+ schemas_allowed_for_csv_upload = fields.List(fields.String())
Review comment:
It should be `String()` here. `Str` is an alias of `String` (see bottom of https://marshmallow.readthedocs.io/en/stable/_modules/marshmallow/fields.html).
##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -1300,3 +1302,23 @@ export function createCtasDatasource(vizOptions) {
});
};
}
+
+export function queryEditorSetFunctionNames(queryEditor, dbId) {
+ return function (dispatch) {
+ return SupersetClient.get({
+ endpoint: encodeURI(`/api/v1/database/${dbId}/function_names/`),
+ })
+ .then(({ json }) =>
+ dispatch({
+ type: QUERY_EDITOR_SET_FUNCTION_NAMES,
+ queryEditor,
+ functionNames: json.function_names,
+ }),
+ )
+ .catch(() =>
+ dispatch(
+ addDangerToast(t('An error occurred while fetching function names')),
Review comment:
Will fix, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (150b55e) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `16.21%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
===========================================
- Coverage 67.00% 50.78% -16.22%
===========================================
Files 1022 477 -545
Lines 50105 17211 -32894
Branches 5191 4444 -747
===========================================
- Hits 33572 8741 -24831
+ Misses 16402 8470 -7932
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.78% <80.00%> (-0.14%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ø> (-1.62%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `50.00% <0.00%> (-2.95%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.89% <83.33%> (-40.01%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `57.53% <100.00%> (-3.23%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.62% <100.00%> (-22.46%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| ... and [894 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...150b55e](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12840:
URL: https://github.com/apache/superset/pull/12840#discussion_r568936755
##########
File path: superset-frontend/src/SqlLab/actions/sqlLab.js
##########
@@ -1300,3 +1302,23 @@ export function createCtasDatasource(vizOptions) {
});
};
}
+
+export function queryEditorSetFunctionNames(queryEditor, dbId) {
+ return function (dispatch) {
+ return SupersetClient.get({
+ endpoint: encodeURI(`/api/v1/database/${dbId}/function_names/`),
+ })
+ .then(({ json }) =>
+ dispatch({
+ type: QUERY_EDITOR_SET_FUNCTION_NAMES,
+ queryEditor,
+ functionNames: json.function_names,
+ }),
+ )
+ .catch(() =>
+ dispatch(
+ addDangerToast(t('An error occurred while fetching function names')),
Review comment:
Will fix, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] betodealmeida commented on a change in pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
betodealmeida commented on a change in pull request #12840:
URL: https://github.com/apache/superset/pull/12840#discussion_r568936661
##########
File path: superset/databases/schemas.py
##########
@@ -413,11 +413,15 @@ class DatabaseRelatedObjectsResponse(Schema):
dashboards = fields.Nested(DatabaseRelatedDashboards)
+class DatabaseFunctionNamesResponse(Schema):
+ function_names = fields.List(fields.String())
+
+
class ImportV1DatabaseExtraSchema(Schema):
metadata_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
engine_params = fields.Dict(keys=fields.Str(), values=fields.Raw())
metadata_cache_timeout = fields.Dict(keys=fields.Str(), values=fields.Integer())
- schemas_allowed_for_csv_upload = fields.List(fields.String)
+ schemas_allowed_for_csv_upload = fields.List(fields.String())
Review comment:
It should be `String()` here. `Str` is an alias of `String` (see bottom of https://marshmallow.readthedocs.io/en/stable/_modules/marshmallow/fields.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (150b55e) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `16.58%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
===========================================
- Coverage 67.00% 50.41% -16.59%
===========================================
Files 1022 477 -545
Lines 50105 17211 -32894
Branches 5191 4444 -747
===========================================
- Hits 33572 8677 -24895
+ Misses 16402 8534 -7868
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.41% <80.00%> (-0.51%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ø> (-1.62%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `50.00% <0.00%> (-2.95%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <ø> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `18.44% <83.33%> (-45.46%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `57.53% <100.00%> (-3.23%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `12.70% <100.00%> (-27.38%)` | :arrow_down: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `6.25% <0.00%> (-93.75%)` | :arrow_down: |
| ... and [894 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...150b55e](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12840: feat: add separate endpoint to fetch function names for autocomplete
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12840:
URL: https://github.com/apache/superset/pull/12840#issuecomment-771180480
# [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=h1) Report
> Merging [#12840](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=desc) (4317a8f) into [master](https://codecov.io/gh/apache/superset/commit/a0e05a5eff51a117ff8427967d14fe8758a81332?el=desc) (a0e05a5) will **decrease** coverage by `7.96%`.
> The diff coverage is `88.00%`.
[](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12840 +/- ##
==========================================
- Coverage 67.00% 59.04% -7.97%
==========================================
Files 1022 965 -57
Lines 50105 47403 -2702
Branches 5191 4446 -745
==========================================
- Hits 33572 27988 -5584
- Misses 16402 19415 +3013
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <80.00%> (-0.09%)` | :arrow_down: |
| javascript | `?` | |
| python | `63.71% <93.33%> (-0.36%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `54.46% <ø> (-1.62%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `50.00% <0.00%> (-2.95%)` | :arrow_down: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `50.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `23.89% <83.33%> (-40.01%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.93% <91.66%> (-0.09%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `57.53% <100.00%> (-3.23%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `17.62% <100.00%> (-22.46%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `99.45% <100.00%> (+<0.01%)` | :arrow_up: |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [425 more](https://codecov.io/gh/apache/superset/pull/12840/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=footer). Last update [a0e05a5...4317a8f](https://codecov.io/gh/apache/superset/pull/12840?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org