You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by shazron <gi...@git.apache.org> on 2016/10/08 00:22:31 UTC
[GitHub] cordova-ios pull request #267: CB-11970 - Support CocoaPod pod specification...
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-ios/pull/267
CB-11970 - Support CocoaPod pod specification other than version
### Platforms affected
iOS
### What does this PR do?
Add support for CocoaPod specs that are not just versions, but other specifications.
i.e.
```
<framework src="MyPod" type="podspec" spec=":configurations => ['Debug', 'Beta']" />
<framework src="MyVersionedPod" type="podspec" spec="1.2" />
```
### What testing has been done on this change?
npm run unit-tests
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-ios CB-11970
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #267
----
commit a24a69d725cbc468feafd0d0a29b643541e320fd
Author: Shazron Abdullah <sh...@apache.org>
Date: 2016-10-08T00:19:16Z
CB-11970 - Support CocoaPod pod specification other than version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #267: CB-11970 - Support CocoaPod pod specification...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #267: CB-11970 - Support CocoaPod pod specification other ...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/267
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) is 56.60% (diff: 87.50%)
> Merging [#267](https://codecov.io/gh/apache/cordova-ios/pull/267?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will increase coverage by **0.10%**
```diff
@@ master #267 diff @@
==========================================
Files 12 12
Lines 1230 1233 +3
Methods 198 198
Messages 0 0
Branches 193 193
==========================================
+ Hits 695 698 +3
Misses 535 535
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [a956c93...06dbae8](https://codecov.io/gh/apache/cordova-ios/compare/a956c93e2cf9f5f23b1880fdd0d43a9f0d113521...06dbae8dcf38ea32993519c974795fb2935910b8?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org