You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 02:38:02 UTC

[GitHub] [arrow] kou commented on a change in pull request #8881: ARROW-9400: [Python] Do not depend on conda-forge static libraries in Windows wheel builds

kou commented on a change in pull request #8881:
URL: https://github.com/apache/arrow/pull/8881#discussion_r553702785



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2124,9 +2124,20 @@ macro(build_re2)
   set_target_properties(re2::re2
                         PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}"
                                    INTERFACE_INCLUDE_DIRECTORIES "${RE2_PREFIX}/include")
+  if(NOT TARGET re2::re2)
+    add_library(re2::re2 STATIC IMPORTED)
+    set_target_properties(
+      re2::re2
+      PROPERTIES IMPORTED_LOCATION "${RE2_STATIC_LIB}" INTERFACE_INCLUDE_DIRECTORIES
+                 "${RE2_PREFIX}/include")
+  endif()

Review comment:
       Can we remove this because we always add `re2::re2` library at the above line.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org