You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/18 01:30:49 UTC

[GitHub] [skywalking-rocketbot-ui] heihaozi opened a new issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

heihaozi opened a new issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447


   When the topological radiation diagram is displayed, there is no change to the corresponding button.
   
   As shown below:
   
   ![](https://user-images.githubusercontent.com/2956927/111559877-4f648d00-87cc-11eb-858d-894b04d81488.jpg)
   
   For a better user experience, the corresponding button should be highlighted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801558600


   @heihaozi you should consider updating the main repo's UI submodule, and sync the changelog. There are several commits landed here made by you and other contributors.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801903943


   Check your local git changes, you could find the commit id change(from...to). Then you could have full list of changes here, https://github.com/apache/skywalking-rocketbot-ui/commits/master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] heihaozi edited a comment on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
heihaozi edited a comment on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801876762


   I have updated main repo's UI submodule in [my branch](https://github.com/heihaozi/skywalking/commit/268dacc8d29d61fb983bd660dfc6ec1a7558947f). As shown below:
   
   ![](https://user-images.githubusercontent.com/2956927/111622920-b57cfe80-8824-11eb-8ae8-b0b60c4b6ae5.png)
   
   But I only know what I modified, and there is no way to update the change log including all other contributors. 
   How do I find changes made by other contributors? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] heihaozi commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
heihaozi commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801672187


   > 
   > 
   > @heihaozi you should consider updating the main repo's UI submodule, and sync the changelog. There are several commits landed here made by you and other contributors.
   
   How to update the main repo's UI submodule? I still don't know very well, please give me more tips.
   
   What you mean by sync the changelog, is it to resubmit the PR for [CHANGES.md](https://github.com/apache/skywalking/blob/master/CHANGES.md)?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] heihaozi commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
heihaozi commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801876762


   I have updated main repo's UI submodule in [my branch](https://github.com/heihaozi/skywalking/commit/268dacc8d29d61fb983bd660dfc6ec1a7558947f). As shown below:
   
   ![](https://user-images.githubusercontent.com/2956927/111622920-b57cfe80-8824-11eb-8ae8-b0b60c4b6ae5.png)
   
   But I only know what I modified, and there is no way to update the change log including all other contributors. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] heihaozi commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
heihaozi commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-802442698


   This is a good idea, I have found it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] Fine0830 closed issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
Fine0830 closed issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on issue #447: When the topology radiation chart is displayed, the corresponding button should be highlighted.

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #447:
URL: https://github.com/apache/skywalking-rocketbot-ui/issues/447#issuecomment-801779102


   Read git submodule document, then you will notice we are using that to link main repo and rocketbot-ui repo.
   Changelog is the file you linked, once you update the submodule, you should update all related changes in that file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org