[jira] [Commented] (TS-2157) Replace "addr" with appropriate "src_addr" and "dst_addr" in ConnectionAttributes

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112907#comment-15112907 ] 

ASF subversion and git services commented on TS-2157:
-----------------------------------------------------

Commit 4ce267d2a6ff9db1d135ff989d862bb60196b04f in trafficserver's branch refs/heads/6.1.x from [~cschombu]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4ce267d ]

TS-4070: RemapProcessor Forward Mapping w/ Recv Port failing w/ TS-2157 changes.
This closes #375.

During the rework of RemapProcessor.cc, RemapProcessor::setup_for_remap()
as part of the TS-2157 changeset, the port access API appears to have been
incorrectly modified to use the client_info.src_addr.host_order_port() API
[source port, host order] instead of the client_info.dst_addr.port()
[destination/receive port, network order] API. This caused port based
remapping based on the receive port to fail with ATS 6.0.0.

(cherry picked from commit 894ef7f859772508331bdb610036baa9fafe81c6)


> Replace "addr" with appropriate "src_addr" and "dst_addr" in ConnectionAttributes
> ---------------------------------------------------------------------------------
>
>                 Key: TS-2157
>                 URL: https://issues.apache.org/jira/browse/TS-2157
>             Project: Traffic Server
>          Issue Type: New Feature
>          Components: Network
>            Reporter: Leif Hedstrom
>            Assignee: Eric Schwartz
>             Fix For: 6.0.0
>
>
> This would more clearly let us encapsulate the two endpoint's (IpEndpoint) for each connection. In addition, we ought to be able to remove the "port" member from ConnectionAttributes as well, and its convoluted and overloaded semantics. The appropriate IpEndpoint (src_addr or dst_addr) would hold the port information as necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)