You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2025/10/13 03:31:26 UTC
[PR] Open Favorites tab on first project or file open [netbeans]
mbien opened a new pull request, #8908:
URL: https://github.com/apache/netbeans/pull/8908
- tab group will now contain 4 views: Projects, Files, Favorites and Services
- will be opened with the already existing on-first-project-open mechanism
- the very first on-editor-open event will also open the Favorites tab
<img width="325" height="246" alt="image" src="https://github.com/user-attachments/assets/45bf5a3c-9036-402e-9a16-6bfa283b555e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3399022810
Sorry, a wrong assumption on how this was handled based on long time platform projects that have obviously overridden the defaults.
If it behaves similarly to Project and Files, both with or without ergonomics, all good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2426310893
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
Because it's handled in ergonomics. Which actually makes me wonder whether this behaviour needs to be part of ergonomics too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8908:
URL: https://github.com/apache/netbeans/pull/8908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3403556524
> The long term solution would be likely setting fixed initial sizes in px (as mentioned before), but they would have to scale with the UI scaling factor.
There are a couple of different UI scaling factors at work. The HiDPI scaling from the operating system would not impact the minimum width, as Swing operates in "logical" pixels rather than device pixels. NetBeans properties such as "fontsize" would affect the minimum width needed to avoid abbreviation, but for the cases where people are tweaking those, I think it would be fine to just require those users to adjust the sidebar width manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3399576510
made two changes:
- added `wasOpened()` check to take the scenario into account when a user closes it right after opening the first project, in that case it should not open again after the first file is opened
- made west column 5% smaller for testing purposes (still too large IMO)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3403829148
a platform test is failing. will investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3924198862
NB 29 will also have some improvements to that behavior: https://github.com/apache/netbeans/pull/9186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2427021652
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
you can load all clusters and no tabs will open. they open on first project open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3407147518
Thanks for doing this!
Just because I've only just had a chance to follow up ...
> Please be specific while reviewing or discussing. I heard that several times that the sidebar doesn't fit the tabs, but couldn't reproduce it even once.
Me neither, although the machine I'm using now while travelling is tightest. It's an Arm Chromebook - native resolution is actually 1920x1200, but the default (and good for my eyes!) is scaled to 1440x900. That can actually go to 24% before the tabs don't fit. That does assume no project group is set though, and this does cover reset windows as well as first run.
If you come back to this then the two `explorer.wsmode` files should probably be kept in sync with any change. Curiously, the value from `navigator.wsmode` does seem to be used whether smaller or bigger - would expect maximum of the two - not sure if that's a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3403621185
> My conclusion: If a minimum width in "swing" pixels could be specified for the sidebar, that would solve the problem.
right. That is what I mean since swing pixels do scale already. The west column needs about 350 pixels right now (includes extra wiggle room for fonts) when scaling is disabled. For 200% scaling it would need about twice as much, but the scaling factor itself would do that already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2426284241
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
Why is this code needed for Favorites but not Projects/Files?
(The PR description mentions an "existing on-first-project-open mechanism", but this seems like a new mechanism?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "pkirkham (via GitHub)" <gi...@apache.org>.
pkirkham commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3924182198
> I had trouble disabling this feature, as it's irrelevant in my Netbeans app. I share my solution here, it might help others.
>
> In my layer.xml:
>
> ```
> <folder name="Preferences">
> <folder name="org">
> <folder name="netbeans">
> <folder name="modules">
> <file name="favorites.properties" url="favorites.properties"/>
> </folder>
> </folder>
> </folder>
> </folder>
> ```
>
> And I added a `favorites.properties` file in the same directory than xml with `initial-open-done=true`
Confirming that this works in my NetBeans platform application too. Favorites is no longer opening at first application startup. Thanks for the explanation @jjazzboss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2426310893
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
~~Because it's handled in ergonomics. Which actually makes me wonder whether this behaviour needs to be part of ergonomics too?~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3403459611
Here's how a fresh NetBeans installation (deleted user dir) would open on a 2024 MacBook Air with 200% HiDPI scaling, if Favorites is open and the the default sidebar width was 25% instead of 30%:
<img width="2304" height="288" alt="image" src="https://github.com/user-attachments/assets/28700c11-11a9-481c-810f-e5356726b038" />
The window does in fact not maximize by default on MacOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3403535866
thanks for testing! The long term solution would be likely setting fixed initial sizes (as mentioned before), but they would have to scale with the UI scaling factor.
25% on 1080p looks nearly half empty. So it makes sense that when scaled 2x it would be slightly too small. (this PR reverted to 30% again, making no changes to the layout)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3399860942
> Do MacOS users normally maximize their windows?
I don't know, but I had raspi users and embedded in mind for the 720p scenario. For mac even the windowed mode will be larger then 720p. On 1920x1080 NB opens as ~1700pix wide window where 25% is already wider than necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3400891518
I'm a little sceptical at adding a tab _and_ lowering the width in the same PR if you're targetting freeze. At least one system I tested on the mailing list thread was fairly tight with all four. UI scaling also has an impact. OTOH, the width can always be put back in at a later RC I guess. :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3399384901
> the current default sidebar width is in ide/spi.navigator/src/org/netbeans/modules/navigator/resources/navigator.wsmode , which is 30%. That should be enough.
oh wow. I was actually searching for that. For some reason I didn't make the connection that the west column is called navigator. I assumed that [windowmanager.wswmr](https://github.com/apache/netbeans/blob/52264d2818e58348484aed8d80eee2e6786ccfd2/platform/core.windows/src/org/netbeans/core/windows/resources/windowmanager/windowmanager.wswmgr) would set the initial layout, but editing numbers there did nothing.
I wanted to reduce that value to give the editor more space. Its unfortunate that it only supports relative values for initial sizing.
30% for a side panel is already too large for regular 1080p (its almost 600px wide) - this is going to be worse on higher resolutions.
25% would still work on 720p according to my measuring stick, assuming the window is maximized first. Should we change it?
<img width="1282" height="243" alt="image" src="https://github.com/user-attachments/assets/f8d353da-e2e8-4f5c-8cd9-cb3c2d9ac152" />
btw the optimal value for 1080p would be ~16% when maximized, _half_ of the current width ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "jjazzboss (via GitHub)" <gi...@apache.org>.
jjazzboss commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3693454591
I had trouble disabling this feature, as it's irrelevant in my Netbeans app. I share my solution here, it might help others.
In my layer.xml:
```
<folder name="Preferences">
<folder name="org">
<folder name="netbeans">
<folder name="modules">
<file name="favorites.properties" url="favorites.properties"/>
</folder>
</folder>
</folder>
</folder>
```
And I added a `favorites.properties` file in the same directory than xml with `initial-open-done=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3398600874
> I think this should probably be open by default unless ergonomics is in play, and the logic for opening with files handled in there?
not completely sure what open by default means. If you mean to open it on first launch without any trigger, I thought about it and tried it, but it looks weird next to the welcome page. Your comment at https://github.com/apache/netbeans/issues/8744#issuecomment-3212181121 sounded like you don't like that idea either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3397460516
Thanks for this! Do we also need to do something to ensure a minimum sidebar width to fit the tabs without abbreviation of tab names?
On a MacBook Air with 200% HiDPI scaling, the sidebar needs about 25% of the screen width to avoid abbreviation.
<img width="1256" height="128" alt="image" src="https://github.com/user-attachments/assets/684aa91d-bdb1-4c15-9c30-549fb48f142c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3401719070
> I'm a little sceptical at adding a tab and lowering the width in the same PR if you're targetting freeze.
Agree with this. For making the sidebar narrower, I think it would be better to add a feature to the window system to allow a constant pixel width to be specified as the initial default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3402986141
going to revert the 5% reduction. Please be specific while reviewing or discussing. I heard that several times that the sidebar doesn't fit the tabs, but couldn't reproduce it even once. In all realistic cases it was too large or far too large (like the 1080p case). Matthias did try to reproduce the issue too during the discussion on the dev list since it was mentioned there too and he couldn't either. Lets not waste all our time by being so vague.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2427574031
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
> Is this meant for existing users of NetBeans rather than new users?
NB doesn't import UI state on upgrade, this means that the window layout always looks the same on very first launch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3399814135
> 25% would still work on 720p according to my measuring stick, assuming the window is maximized first. Should we change it?
Do MacOS users normally maximize their windows? I had to install a special window tiler app (SizeUp) to make maximization easy... otherwise if you press the green window button thing it just goes into a very useless full screen mode thing.
In my platform app I have special code for maximizing the window on startup. But the "out of the box" experience for the NetBeans IDE might well be the narrower unmaximized state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#issuecomment-3397479145
I think this should probably be open by default unless ergonomics is in play, and the logic for opening with files handled in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2427020762
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
AFAIK the Projects/Files group isn't handled by ergonomics
1) the tab group is set up via regular config
2) code is then opening the group on project open, it even has logic to close it again but it isn't working for some reason
https://github.com/apache/netbeans/blob/083a13a24d4b4a4023b84a2faefb3f4a630808fa/ide/projectuiapi/src/org/netbeans/modules/project/uiapi/OpenProjectsListener.java#L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2426302802
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
+ private void attachFirstEditorOpenListener() {
+ Preferences prefs = NbPreferences.forModule(Module.class);
+ if (!prefs.getBoolean(INITIAL_OPEN_DONE_KEY, false)) {
+ WindowManager.getDefault().addPropertyChangeListener(new PropertyChangeListener() {
+ @Override
+ public void propertyChange(PropertyChangeEvent evt) {
+ if ("activeMode".equals(evt.getPropertyName()) //NOI18N
+ && evt.getNewValue() instanceof Mode mode
+ && "editor".equals(mode.getName())) { //NOI18N
Review Comment:
Or `WindowManager::isEditorMode`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Open Favorites tab on first project or file open [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on code in PR #8908:
URL: https://github.com/apache/netbeans/pull/8908#discussion_r2426284241
##########
platform/favorites/src/org/netbeans/modules/favorites/Module.java:
##########
@@ -53,10 +68,38 @@ public void run() {
shortcuts.add(file);
}
}
- return shortcuts.toArray(new File[0]);
+ return shortcuts.toArray(File[]::new);
};
UIManager.put(LFCustoms.FILECHOOSER_SHORTCUTS_FILESFUNCTION, favAppender);
}
+
+ // very first open editor tab event will also open the Favorites tab
Review Comment:
Why is this code needed for Favorites but not Projects/Files?
(The PR description mentions an "existing on-first-project-open mechanism", but this seems like a new mechanism? EDIT: Ah, I see this is a separate bullet.)
Is this meant for existing users of NetBeans rather than new users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists