[GitHub] [pulsar] eolivelli commented on a change in pull request #10093: [Broker] Add time based backlog quota

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #10093:
URL: https://github.com/apache/pulsar/pull/10093#discussion_r605390325



##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/BacklogQuota.java
##########
@@ -28,16 +28,27 @@
  * <code>limit</code> representing a quota limit in bytes and <code>policy</code> for backlog retention policy.
  */
 public class BacklogQuota {
-    private long limit;
+    private long limitSize;
+    // backlog quota by time in second
+    private int limitTime;
     private RetentionPolicy policy;
 
     /**
-     * Gets quota limit in bytes.
+     * Gets quota limit in size.
      *
      * @return quota limit in bytes
      */
-    public long getLimit() {
-        return limit;
+    public long getLimitSize() {

Review comment:
       This object is serialized, changing the name is a breaking change.
   Are we handling compatibility with old configurations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org